Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpkg, pika web support #2

Closed
bahrus opened this issue Oct 31, 2019 · 5 comments
Closed

unpkg, pika web support #2

bahrus opened this issue Oct 31, 2019 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@bahrus
Copy link

bahrus commented Oct 31, 2019

Component looks really nice!

I tried using this component using cdn support.

You can see my attempts here: https://github.com/bahrus/hypo-link/blob/master/demo/syntax.html

One of the attempts is commented out.

Neither worked, for different reasons.

Hoping this can be fixed (if it hasn't already).

@web-padawan
Copy link
Collaborator

Thanks for the issue. The problem is most likely related to the fact that marked and prismjs do not provide ES module version - this is what Pika uses per module field in package.json.

See also markedjs/marked#1288

If you know any better replacement for these libraries, please let me know and I will give it a try.

@web-padawan web-padawan added the help wanted Extra attention is needed label Nov 2, 2019
@web-padawan
Copy link
Collaborator

Good news: marked will support ES modules in the upcoming 0.8.0 release: markedjs/marked#1571

I will update to that version alongside with the new web-component-analyzer.

@web-padawan
Copy link
Collaborator

web-padawan commented Dec 4, 2019

Looks like illuminate-js (which is written in TS and supports ES modules) can be used instead of prismjs. My only concern is that Illuminate is alpha and does not seem to be maintained.

https://github.com/vkbansal/illuminate-js

@web-padawan
Copy link
Collaborator

Good news: marked 0.8.0 is now released with ES modules
Bad news: they have removed the "module" field 😞

Submitted FredKSchott/analyze-npm#9 to discuss possible alternatives.

@web-padawan
Copy link
Collaborator

I have released 0.3.0 which adds https://unpkg.com CDN support.

Regarding pika, we should focus on fixing the issue mentioned above.
So let me close this issue for now and continue discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants