diff --git a/crates/weaver_codegen_test/semconv_registry/registry/error.yaml b/crates/weaver_codegen_test/semconv_registry/registry/error.yaml index f9579551..893cf8cb 100644 --- a/crates/weaver_codegen_test/semconv_registry/registry/error.yaml +++ b/crates/weaver_codegen_test/semconv_registry/registry/error.yaml @@ -36,4 +36,6 @@ groups: it's RECOMMENDED to: * Use a domain-specific attribute - * Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not. \ No newline at end of file + * Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + + And something more. \ No newline at end of file diff --git a/crates/weaver_forge/data/mini_registry_for_comments/error.yaml b/crates/weaver_forge/data/mini_registry_for_comments/error.yaml index 23b8234b..c46cbcdb 100644 --- a/crates/weaver_forge/data/mini_registry_for_comments/error.yaml +++ b/crates/weaver_forge/data/mini_registry_for_comments/error.yaml @@ -36,4 +36,6 @@ groups: it's RECOMMENDED to: * Use a domain-specific attribute - * Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not. \ No newline at end of file + * Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + + And something more. \ No newline at end of file diff --git a/crates/weaver_forge/expected_output/comment_format/example.go b/crates/weaver_forge/expected_output/comment_format/example.go index 5802463c..555f7110 100644 --- a/crates/weaver_forge/expected_output/comment_format/example.go +++ b/crates/weaver_forge/expected_output/comment_format/example.go @@ -83,6 +83,8 @@ const DNS_QUESTION_NAME = "" // - Use a domain-specific attribute // - Set `error.type` to capture all errors, regardless of whether they are // defined within the domain-specific set or not +// +// And something more const ERROR_TYPE = "" // Examples of comments for group other diff --git a/crates/weaver_forge/expected_output/comment_format/example.java b/crates/weaver_forge/expected_output/comment_format/example.java index c657c358..346f9454 100644 --- a/crates/weaver_forge/expected_output/comment_format/example.java +++ b/crates/weaver_forge/expected_output/comment_format/example.java @@ -64,6 +64,7 @@ *
  • Use a domain-specific attribute *
  • Set {@code error.type} to capture all errors, regardless of whether they are defined within the domain-specific set or not * + * And something more */ static ERROR_TYPE = ""; diff --git a/crates/weaver_forge/expected_output/comment_format/example.py b/crates/weaver_forge/expected_output/comment_format/example.py index dc4e1e60..f0195ff4 100644 --- a/crates/weaver_forge/expected_output/comment_format/example.py +++ b/crates/weaver_forge/expected_output/comment_format/example.py @@ -56,6 +56,8 @@ - Use a domain-specific attribute - Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + + And something more """ ATTR: Final = "" diff --git a/crates/weaver_forge/expected_output/comment_format/example.rs b/crates/weaver_forge/expected_output/comment_format/example.rs index a666e46e..898a0e5c 100644 --- a/crates/weaver_forge/expected_output/comment_format/example.rs +++ b/crates/weaver_forge/expected_output/comment_format/example.rs @@ -52,6 +52,8 @@ /// /// - Use a domain-specific attribute /// - Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + /// + /// And something more const ERROR_TYPE: &str = ""; diff --git a/crates/weaver_forge/src/extensions/code.rs b/crates/weaver_forge/src/extensions/code.rs index 736e3561..1d15d2b4 100644 --- a/crates/weaver_forge/src/extensions/code.rs +++ b/crates/weaver_forge/src/extensions/code.rs @@ -334,7 +334,9 @@ If a specific domain defines its own set of error identifiers (such as HTTP or g it's RECOMMENDED to: * Use a domain-specific attribute -* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not.. "#; +* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + +And something more.. "#; let ctx = serde_json::json!({ "note": note }); @@ -368,6 +370,7 @@ it's RECOMMENDED to: *
  • Use a domain-specific attribute *
  • Set {@code error.type} to capture all errors, regardless of whether they are defined within the domain-specific set or not * + * And something more */"## ); @@ -398,6 +401,7 @@ it's RECOMMENDED to: *
  • Use a domain-specific attribute *
  • Set {@code error.type} to capture all errors, regardless of whether they are defined within the domain-specific set or not * + * And something more */"## ); @@ -428,6 +432,7 @@ it's RECOMMENDED to: *
  • Use a domain-specific attribute *
  • Set {@code error.type} to capture all errors, regardless of whether they are defined within the domain-specific set or not * + * And something more */"## ); @@ -458,6 +463,7 @@ it's RECOMMENDED to: *
  • Use a domain-specific attribute *
  • Set {@code error.type} to capture all errors, regardless of whether they are defined within the domain-specific set or not * + * And something more */"## ); @@ -517,6 +523,7 @@ it's RECOMMENDED to: * are defined within the * domain-specific set or not * + * And something more */"## ); diff --git a/crates/weaver_forge/src/formats/html.rs b/crates/weaver_forge/src/formats/html.rs index 59c427bf..641ccaf6 100644 --- a/crates/weaver_forge/src/formats/html.rs +++ b/crates/weaver_forge/src/formats/html.rs @@ -528,7 +528,9 @@ If a specific domain defines its own set of error identifiers (such as HTTP or g it's RECOMMENDED to: * Use a domain-specific attribute -* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not."##; +* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + +And something more."##; let html = renderer.render(markdown, "java", None)?; assert_string_eq!( &html, @@ -550,9 +552,9 @@ If a specific domain defines its own set of error identifiers (such as HTTP or g it's RECOMMENDED to: -"## +And something more."## ); Ok(()) } @@ -728,7 +730,9 @@ If a specific domain defines its own set of error identifiers (such as HTTP or g it's RECOMMENDED to: * Use a domain-specific attribute -* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not."##; +* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + +And something more."##; let html = renderer.render(markdown, "java", None)?; assert_string_eq!( &html, @@ -776,9 +780,9 @@ RECOMMENDED to: capture all errors, regardless of whether they are defined within the - domain-specific set or not. + domain-specific set or not -"## +And something more."## ); Ok(()) } diff --git a/crates/weaver_forge/src/formats/markdown.rs b/crates/weaver_forge/src/formats/markdown.rs index 4e96488a..7a1fb578 100644 --- a/crates/weaver_forge/src/formats/markdown.rs +++ b/crates/weaver_forge/src/formats/markdown.rs @@ -628,7 +628,9 @@ If a specific domain defines its own set of error identifiers (such as HTTP or g it's RECOMMENDED to: * Use a domain-specific attribute -* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not."##; +* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + +And something more."##; let rendered_md = renderer.render(markdown, "go", None)?; assert_string_eq!( &rendered_md, @@ -650,7 +652,10 @@ If a specific domain defines its own set of error identifiers (such as HTTP or g it's RECOMMENDED to: - Use a domain-specific attribute - - Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not."## + - Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + +And something more. +"## ); let config = WeaverConfig { @@ -835,7 +840,9 @@ If a specific domain defines its own set of error identifiers (such as HTTP or g it's RECOMMENDED to: * Use a domain-specific attribute -* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not."##; +* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + +And something more."##; let rendered_md = renderer.render(markdown, "go", None)?; assert_string_eq!( &rendered_md, @@ -881,7 +888,10 @@ RECOMMENDED to: all errors, regardless of whether they are defined within the domain-specific - set or not."## + set or not + +And something more. +"## ); let config = WeaverConfig { diff --git a/crates/weaver_resolver/data/registry-test-3-extends/expected-attribute-catalog.json b/crates/weaver_resolver/data/registry-test-3-extends/expected-attribute-catalog.json index 21f39587..cb8bf530 100644 --- a/crates/weaver_resolver/data/registry-test-3-extends/expected-attribute-catalog.json +++ b/crates/weaver_resolver/data/registry-test-3-extends/expected-attribute-catalog.json @@ -20,7 +20,7 @@ "500" ], "requirement_level": "recommended", - "note": "The `error.type` SHOULD be predictable and SHOULD have low cardinality.\nInstrumentations SHOULD document the list of errors they report.\n\nThe cardinality of `error.type` within one instrumentation library SHOULD be low.\nTelemetry consumers that aggregate data from multiple instrumentation libraries and applications\nshould be prepared for `error.type` to have high cardinality at query time when no\nadditional filters are applied.\n\nIf the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.\n\nIf a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),\nit's RECOMMENDED to:\n\n* Use a domain-specific attribute\n* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not.", + "note": "The `error.type` SHOULD be predictable and SHOULD have low cardinality.\nInstrumentations SHOULD document the list of errors they report.\n\nThe cardinality of `error.type` within one instrumentation library SHOULD be low.\nTelemetry consumers that aggregate data from multiple instrumentation libraries and applications\nshould be prepared for `error.type` to have high cardinality at query time when no\nadditional filters are applied.\n\nIf the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.\n\nIf a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),\nit's RECOMMENDED to:\n\n* Use a domain-specific attribute\n* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not\n\nAnd something more.", "stability": "stable" }, { @@ -1203,7 +1203,7 @@ "requirement_level": { "conditionally_required": "If and only if the messaging operation has failed." }, - "note": "The `error.type` SHOULD be predictable and SHOULD have low cardinality.\nInstrumentations SHOULD document the list of errors they report.\n\nThe cardinality of `error.type` within one instrumentation library SHOULD be low.\nTelemetry consumers that aggregate data from multiple instrumentation libraries and applications\nshould be prepared for `error.type` to have high cardinality at query time when no\nadditional filters are applied.\n\nIf the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.\n\nIf a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),\nit's RECOMMENDED to:\n\n* Use a domain-specific attribute\n* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not.", + "note": "The `error.type` SHOULD be predictable and SHOULD have low cardinality.\nInstrumentations SHOULD document the list of errors they report.\n\nThe cardinality of `error.type` within one instrumentation library SHOULD be low.\nTelemetry consumers that aggregate data from multiple instrumentation libraries and applications\nshould be prepared for `error.type` to have high cardinality at query time when no\nadditional filters are applied.\n\nIf the operation has completed successfully, instrumentations SHOULD NOT set `error.type`.\n\nIf a specific domain defines its own set of error identifiers (such as HTTP or gRPC status codes),\nit's RECOMMENDED to:\n\n* Use a domain-specific attribute\n* Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not\n\nAnd something more.", "stability": "stable" }, { diff --git a/crates/weaver_resolver/data/registry-test-3-extends/registry/registry-error.yaml b/crates/weaver_resolver/data/registry-test-3-extends/registry/registry-error.yaml index 505321ad..cc47904e 100644 --- a/crates/weaver_resolver/data/registry-test-3-extends/registry/registry-error.yaml +++ b/crates/weaver_resolver/data/registry-test-3-extends/registry/registry-error.yaml @@ -31,4 +31,6 @@ groups: it's RECOMMENDED to: * Use a domain-specific attribute - * Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not. \ No newline at end of file + * Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + + And something more. \ No newline at end of file diff --git a/data/update_markdown/registry/registry/error.yaml b/data/update_markdown/registry/registry/error.yaml index 6831a7a5..300da10b 100644 --- a/data/update_markdown/registry/registry/error.yaml +++ b/data/update_markdown/registry/registry/error.yaml @@ -32,4 +32,6 @@ groups: it's RECOMMENDED to: * Use a domain-specific attribute - * Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not. \ No newline at end of file + * Set `error.type` to capture all errors, regardless of whether they are defined within the domain-specific set or not + + And something more. \ No newline at end of file