-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semconv schema: don't require attributes on metrics #405
Comments
@lmolkova @jsuereth - I'm happy to take this one on if you would like to assign it to me. It's similar to a PR I just did for group stability: #467 I will change the EBNF and json schema. However, there is currently a difference in this area between the EBNF and the schema. The EBNF currently defines - id: span.db.client
type: span
stability: experimental
brief: This span defines the attributes used to perform database client calls.
span_kind: client
extends: trace.db.common.full Is this a valid case? If so the EBNF should be defined like this |
This is a valid use case. |
Done in #494 |
Json schema validation shows error when metrics is defined without attributes
with
Missing property "attributes".yaml-schema: https://raw.githubusercontent.com/open-telemetry/build-tools/v0.24.0/semantic-conventions/semconv.schema.json
Metrics don't have to have attributes or may inherit them through extension mechanism.
The text was updated successfully, but these errors were encountered: