Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQ errors are suppressed #264

Closed
lmolkova opened this issue Jul 29, 2024 · 1 comment · Fixed by #274
Closed

JQ errors are suppressed #264

lmolkova opened this issue Jul 29, 2024 · 1 comment · Fixed by #274

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Jul 29, 2024

JQ errors are ignored during registry generation / markdown update.

To Reproduce

  1. Define a weaver.yaml like
  - pattern: readme.md.j2
    filter: 'error("foo")' # or do something that'd result in JQ error
   ...

(e.g. change one in semconv https://github.com/open-telemetry/semantic-conventions/blob/a44ff768718b6e82f2dea42189ba14712c795e6b/templates/registry/markdown/weaver.yaml)

  1. Run generation

Expected behavior

  • registry generation fails.
  • JQ error is propagated in the output
  • generation stops

Actual behavior

  • original groups are passed to jinja as if there was no JQ filter
  • generation continues and fails later in jinja templates (if JQ modified the structure) or results in incorrect data (if structure is the same, but filters didn't run),
@lquerel
Copy link
Contributor

lquerel commented Jul 31, 2024

Fixed in #274

@lquerel lquerel closed this as completed Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants