Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change what prefix means in the schema #263

Closed
lmolkova opened this issue Jul 26, 2024 · 2 comments · Fixed by #407
Closed

Change what prefix means in the schema #263

lmolkova opened this issue Jul 26, 2024 · 2 comments · Fixed by #407
Assignees
Labels
enhancement New feature or request

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Jul 26, 2024

Depends on open-telemetry/semantic-conventions#1292 and open-telemetry/semantic-conventions#1293

Once we migrate semaconv tooling to weaver, we can reconsider usage prefix:

  • prefix could be a property that's used to validate that all attributes defined in scope of group have this prefix
    • it could be required to embed things and might be optional in other cases
  • prefix is removed and only used when embedding things.
@lmolkova lmolkova moved this to Clean up YAML schema in Semantic Conventions Tooling Jul 26, 2024
@lmolkova lmolkova changed the title Remove prefix from the schema Change what prefix means on the schema Jul 29, 2024
@lmolkova lmolkova changed the title Change what prefix means on the schema Change what prefix means in the schema Jul 29, 2024
@lmolkova
Copy link
Contributor Author

lmolkova commented Jul 29, 2024

blocked on

@jsuereth
Copy link
Contributor

jsuereth commented Oct 9, 2024

Let's remove prefix form weaver in --future mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants