From d1e2f8fdf10b214c05fcfbbfab060681962db768 Mon Sep 17 00:00:00 2001 From: JamieDanielson Date: Tue, 19 Nov 2024 18:07:13 -0500 Subject: [PATCH 1/3] Fix typo in schemas for messaging attribute changes --- schema-next.yaml | 4 ++-- schemas/1.27.0 | 4 ++-- schemas/1.28.0 | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/schema-next.yaml b/schema-next.yaml index 50afab2b96..de73f27640 100644 --- a/schema-next.yaml +++ b/schema-next.yaml @@ -59,8 +59,8 @@ versions: attribute_map: messaging.kafka.consumer.group: messaging.consumer.group.name messaging.rocketmq.client_group: messaging.consumer.group.name - messaging.evenhubs.consumer.group: messaging.consumer.group.name - message.servicebus.destination.subscription_name: messaging.destination.subscription.name + messaging.eventhubs.consumer.group: messaging.consumer.group.name + messaging.servicebus.destination.subscription_name: messaging.destination.subscription.name # https://github.com/open-telemetry/semantic-conventions/pull/1200 - rename_attributes: attribute_map: diff --git a/schemas/1.27.0 b/schemas/1.27.0 index 00cce6bc26..21052063e4 100644 --- a/schemas/1.27.0 +++ b/schemas/1.27.0 @@ -21,8 +21,8 @@ versions: attribute_map: messaging.kafka.consumer.group: messaging.consumer.group.name messaging.rocketmq.client_group: messaging.consumer.group.name - messaging.evenhubs.consumer.group: messaging.consumer.group.name - message.servicebus.destination.subscription_name: messaging.destination.subscription.name + messaging.eventhubs.consumer.group: messaging.consumer.group.name + messaging.servicebus.destination.subscription_name: messaging.destination.subscription.name # https://github.com/open-telemetry/semantic-conventions/pull/1200 - rename_attributes: attribute_map: diff --git a/schemas/1.28.0 b/schemas/1.28.0 index 2b1311aaf4..2afee1ce42 100644 --- a/schemas/1.28.0 +++ b/schemas/1.28.0 @@ -27,8 +27,8 @@ versions: attribute_map: messaging.kafka.consumer.group: messaging.consumer.group.name messaging.rocketmq.client_group: messaging.consumer.group.name - messaging.evenhubs.consumer.group: messaging.consumer.group.name - message.servicebus.destination.subscription_name: messaging.destination.subscription.name + messaging.eventhubs.consumer.group: messaging.consumer.group.name + messaging.servicebus.destination.subscription_name: messaging.destination.subscription.name # https://github.com/open-telemetry/semantic-conventions/pull/1200 - rename_attributes: attribute_map: From f75037b4a6aab4f6e908efa9f003b6f746ee24e1 Mon Sep 17 00:00:00 2001 From: JamieDanielson Date: Tue, 19 Nov 2024 18:10:04 -0500 Subject: [PATCH 2/3] add changelog entry --- .chloggen/fix-typo-messaging-schema.yaml | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .chloggen/fix-typo-messaging-schema.yaml diff --git a/.chloggen/fix-typo-messaging-schema.yaml b/.chloggen/fix-typo-messaging-schema.yaml new file mode 100644 index 0000000000..c487a03f06 --- /dev/null +++ b/.chloggen/fix-typo-messaging-schema.yaml @@ -0,0 +1,4 @@ +change_type: 'bug_fix' +component: messaging +note: Fix typo in schemas for messaging attribute changes +issues: [1595] From 74b389e4bdbb1a44518669af9365ea9592d74c3c Mon Sep 17 00:00:00 2001 From: JamieDanielson Date: Tue, 26 Nov 2024 12:14:29 -0500 Subject: [PATCH 3/3] revert changes to published schemas --- schemas/1.27.0 | 4 ++-- schemas/1.28.0 | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/schemas/1.27.0 b/schemas/1.27.0 index 21052063e4..00cce6bc26 100644 --- a/schemas/1.27.0 +++ b/schemas/1.27.0 @@ -21,8 +21,8 @@ versions: attribute_map: messaging.kafka.consumer.group: messaging.consumer.group.name messaging.rocketmq.client_group: messaging.consumer.group.name - messaging.eventhubs.consumer.group: messaging.consumer.group.name - messaging.servicebus.destination.subscription_name: messaging.destination.subscription.name + messaging.evenhubs.consumer.group: messaging.consumer.group.name + message.servicebus.destination.subscription_name: messaging.destination.subscription.name # https://github.com/open-telemetry/semantic-conventions/pull/1200 - rename_attributes: attribute_map: diff --git a/schemas/1.28.0 b/schemas/1.28.0 index 2afee1ce42..2b1311aaf4 100644 --- a/schemas/1.28.0 +++ b/schemas/1.28.0 @@ -27,8 +27,8 @@ versions: attribute_map: messaging.kafka.consumer.group: messaging.consumer.group.name messaging.rocketmq.client_group: messaging.consumer.group.name - messaging.eventhubs.consumer.group: messaging.consumer.group.name - messaging.servicebus.destination.subscription_name: messaging.destination.subscription.name + messaging.evenhubs.consumer.group: messaging.consumer.group.name + message.servicebus.destination.subscription_name: messaging.destination.subscription.name # https://github.com/open-telemetry/semantic-conventions/pull/1200 - rename_attributes: attribute_map: