-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should metrics description be a full sentence? #897
Comments
Looks like a good, non-polemical improvement to make. |
@reyang do you think this is a blocker for HTTP stability? |
I don't think so, worst case I'll send a small PR just to fix the HTTP metrics descriptions (to align with OpenMetrics convention). Assigning this to myself. |
Update: I've scanned through the HTTP metrics semantic conventions and confirmed that all descriptions are now aligned with OpenMetrics convention, so it is not blocking HTTP semantic convention stability. @trask FYI |
OpenMetrics provided such example: https://github.com/OpenObservability/OpenMetrics/blob/main/specification/OpenMetrics.md#overall-structure
The current metrics semantic convention is different (and inconsistent):
Ask:
.
.Additional Ask (not blocking):
The text was updated successfully, but these errors were encountered: