Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event yaml definition should allow to document SeverityNumber #828

Open
lmolkova opened this issue Mar 21, 2024 · 3 comments
Open

Event yaml definition should allow to document SeverityNumber #828

lmolkova opened this issue Mar 21, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Mar 21, 2024

Area(s)

area:events

What happened?

Description

Based on the spec-ed out Event parameters, events have optional SeverityNumber

But none of the existing events document it and it's not covered in the https://github.com/open-telemetry/semantic-conventions/blob/main/docs/general/events.md

Expected Result

We have a way to define and document severity for the events.

Semantic convention version

1.24.0

Additional context

No response

@tedsuo
Copy link
Contributor

tedsuo commented May 31, 2024

@lmolkova I don't think we should associate events with a specific severity number. The severity of an event is based to the context in which the event is occurring, not intrinsic to the event itself.

For example, the same exception may be an error or a warning depending on the context. Other events may be debug, info, or warn depending on their context. Based on that, I don't think it is correct to imply there is a default or "correct" severity for events.

@MSNev
Copy link
Contributor

MSNev commented Jun 17, 2024

@lmolkova lmolkova removed this from Logs SIG Jun 17, 2024
@lmolkova lmolkova changed the title Event semantic convention should document SeverityNumber Event yaml definition should allow to document SeverityNumber Jun 17, 2024
@lmolkova
Copy link
Contributor Author

Discussed at semconv WG 6/17:

  • some events would need severity, we can discuss it when we introduce them. They are emitted by instrumentation libraries (e.g. GenAI response content should probably be Verbose) and severity can be used as the enablement mechanism for such events
  • I've moved it to tooling project since the request here is to be able to specify the severity (i.e. support it in the schema definition and anything derived from it such as codegen)

@lmolkova lmolkova added enhancement New feature or request and removed bug Something isn't working area:other labels Jun 17, 2024
@joaopgrassi joaopgrassi removed their assignment Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants