Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark HTTP semantic conventions as stable in the YAML definitions #82

Closed
arminru opened this issue Jun 5, 2023 · 2 comments · Fixed by #377
Closed

Mark HTTP semantic conventions as stable in the YAML definitions #82

arminru opened this issue Jun 5, 2023 · 2 comments · Fixed by #377
Assignees

Comments

@arminru
Copy link
Member

arminru commented Jun 5, 2023

Our semantic convention tooling defines a property called stability for semantic conventions.
Once we finally stabilize our HTTP conventions, the YAML files should be updated to set this property to stable.

See https://github.com/open-telemetry/build-tools/blob/main/semantic-conventions/syntax.md#syntax for details.

@jsuereth
Copy link
Contributor

jsuereth commented Jul 6, 2023

Is this a blocker for our release?

@arminru
Copy link
Member Author

arminru commented Jul 11, 2023

@jsuereth It's a bit of a chicken and egg thing. Ideally we'd just mark both the MD files and the backing YAML definitions stable in an atomic operation but otherwise either order should be fine as well. If both happens in the same semconv release it will be consistent enough for sure.

Since the upcoming semconv release doesn't mark HTTP stable quite yet it's not a blocker for that release anyway though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants