-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing ECS cloud fields to Semantic Conventions Cloud Resource attributes #761
Comments
How would The description of
|
Good points @pyohannes, due to the plain field structure in ECS, it made sense to add them all but as the below pairs might be mutually exclusive we can consider removing them from the PR.
cc: @mx-psi @ChrsMark @frzifus @dineshg13 @braydonk who worked on the system semantic conventions for comment. |
Agree! Thanks @pyohannes! We are already using |
I think removing |
This seems to also be relevant to #576, #739 and #600 In general I like the idea of re-using the For example we already have the Also we should be very specific on how we leverage the resource hierarchy here. processors:
resourcedetection/system:
detectors: [ "system" ]
system:
hostname_sources: [ "lookup", "cname", "dns", "os" ]
resource_attributes:
host.name:
enabled: true
resourcedetection/gcp:
detectors: [ env, gcp ]
timeout: 2s
override: false a) if we add the This can be very confusing for the users, specially when it comes to multi-tenant infrastructures with multiple teams running multiple Collector's instances per org/team/namespace. So to my mind we should be very specific here and either:
Let me know what you folks think or if I miss something here. |
What
This issue proposes adding cloud-related fields from the Elastic Common Schema (ECS) which are not in the OpenTelemetry Semantic Conventions specification for Cloud Resource Attributes.
Why
These fields provide valuable context, enabling a better understanding and analysis of application performance and behaviour across cloud environments. Analyse performance differences based on cloud configuration (e.g., account name for companies using multiple accounts, machine type to help understand related performance and cost, etc.), and better understand the impact of cloud infrastructure on application behaviour.
List of fields proposed for addition
This PR (currently closed) implements this issue.
The text was updated successfully, but these errors were encountered: