-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adopting more container fields from ECS #72
Comments
I guess we should consider this other issue, and how adopting fields from ECS would work with those from OCI? #48 (comment) |
Good catch @joaopgrassi ! Yeap it seems that for Apart from the |
Since #282 has been merged we can close this as completed 🎂 . Having said this, we can consider the container ECS fields as merged with OpenTelemetry's container SemConvs 🎉 🥳 . |
Based on https://opentelemetry.io/docs/specs/otel/resource/semantic_conventions/container/ the most important Containers' fields are already part of the spec. This issue aims to make a comparison with the respective ECS fields and evaluate the adoption (from ECS) of any fields missing.
Comparison table
Here is a comparison matrix between the ECS container fields and the open-telemetry ones:
Open questions
container.image.tag
field (string VS array). In ECS this is an array storing all of the image's tags but to my mind this is not correct since 1 container will only be linked to 1 image tag. I would agree with what Otel specifies today regarding the type. Most probably the same goes forcontainer.image.hash
.Resources
This is also related to #58 since we might consider using
container.cpu.*
instead ofkubernetes/k8s.container.cpu.*
.The text was updated successfully, but these errors were encountered: