-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db.name should be broken down into individual layers #714
Comments
We need experts here, as well as examples to document actual, specific cases (e.g. different databases). Please consider raising in the semantic convention group with @jsuereth (albeit this is a trace semantic convention). |
The reasoning behind The alternative is to go with more db-specific attributes which use database-specific terminology, e.g. |
I believe we can close this after merging #911, as it clarifies the naming and purpose around this attribute ( |
What are you trying to achieve?
Semantic convention for db client calls (database.md) states that for
db.name
"the database name to be used is the more specific layer". This may cause problems because as a user I don't know beforehand what the tag actually describes. For one db engine the tag may describe the "schema name" and for another a "database name".This approach also makes it difficult to distinguish e.g. between two schemas with the same schema name running under two different instances.
I believe that
db.name
should behave consistently regardless of the database engine used (always store "database name"). Moreover it might be helpful to add more tags to describe database-specific layers (likedb.schema_name
or something similar).Additional context.
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md
The text was updated successfully, but these errors were encountered: