Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce common configuration option for sanitisation of db.statement. #705

Open
Mpdreamz opened this issue Jul 13, 2023 · 0 comments
Open
Assignees

Comments

@Mpdreamz
Copy link

What are you trying to achieve?

Standardise the configuration for the sanitisation of db.statement.

With open-telemetry/opentelemetry-specification#3104 the default for the collection of db.statement is conditional on whether sanitisation is configured/available or not.

While I fully agree with the initiative it has a knock on effect that each LANG and INSTRUMENTATION will start using their own configuration mechanisms to enable the collection of db.statement.

This leads to a fragmented feature set and quite a large configuration burden to our users.

What did you expect to see?

A single OTEL_* environment variable that users can set and that instrumentation can pick up.

OTEL_INSTRUMENTATION_DB_STATEMENT

  • omit default value, discards or prevents the collection of db.statement
  • sanitise
    • instruct instrumentation to sanitise any captured db.statement
    • if no sanitisation mechanism exist for the specific language instrumentation will fall back to omit
  • raw collect any captured db.statement raw without any sanitisation.

Agents in specific languages could further more listen to a more restricted:

OTEL_{LANGUAGE}_INSTRUMENTATION_DB_STATEMENT environment variable that takes precedence over OTEL_INSTRUMENTATION_DB_STATEMENT

To isolate the choice further if so required.

Additional context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Post Stability
Development

No branches or pull requests

3 participants