Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FaaS - Incoming span kind #696

Open
RohitRanjanMS opened this issue Feb 6, 2024 · 6 comments
Open

FaaS - Incoming span kind #696

RohitRanjanMS opened this issue Feb 6, 2024 · 6 comments
Assignees

Comments

@RohitRanjanMS
Copy link

The convention indicates that, based on the faas.trigger, it should adhere to the corresponding semantic convention but the faas span semantic requires that for an incoming span, the span kind must be set as Server.

For incoming FaaS spans, the span kind MUST be Server.

Although Server is suitable for HTTP scenarios, it lacks relevance for scenarios such as PubSub and Timer. Is there a specific rationale for setting Server regardless of the faas.trigger, or can we define a more appropriate kind for each scenario?

@RohitRanjanMS
Copy link
Author

@lmolkova FYI

@pyohannes
Copy link
Contributor

This depends on whether one has different spans for modelling the incoming FaaS operations and for the operation of consuming a message.

If there are different spans for those two operations, then it's fine that the FaaS span is of kind SERVER (as the additional messaging span will have the kind CONSUMER).

If there's only one span used, it should be CONSUMER.

This relates to #652.

@RohitRanjanMS
Copy link
Author

@jviau FYI

@RohitRanjanMS
Copy link
Author

Thanks @pyohannes for the additional context, I will follow #652

@AlexanderWert
Copy link
Member

If there are different spans for those two operations, then it's fine that the FaaS span is of kind SERVER (as the additional messaging span will have the kind CONSUMER).

If there's only one span used, it should be CONSUMER.

Would be good to add this logic to the FaaS Semantic Conventions, to make it explicit.

@joaopgrassi
Copy link
Member

@RohitRanjanMS would you like to submit a PR to add this clarification? OR should we close this all in favor of #652?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants