-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FaaS - Incoming span kind #696
Comments
@lmolkova FYI |
This depends on whether one has different spans for modelling the incoming FaaS operations and for the operation of consuming a message. If there are different spans for those two operations, then it's fine that the FaaS span is of kind If there's only one span used, it should be This relates to #652. |
@jviau FYI |
Thanks @pyohannes for the additional context, I will follow #652 |
Would be good to add this logic to the FaaS Semantic Conventions, to make it explicit. |
@RohitRanjanMS would you like to submit a PR to add this clarification? OR should we close this all in favor of #652? |
The convention indicates that, based on the
faas.trigger
, it should adhere to the corresponding semantic convention but the faas span semantic requires that for an incoming span, the span kind must be set as Server.For incoming FaaS spans, the span kind MUST be Server.
Although
Server
is suitable for HTTP scenarios, it lacks relevance for scenarios such asPubSub
andTimer
. Is there a specific rationale for settingServer
regardless of thefaas.trigger
, or can we define a more appropriate kind for each scenario?The text was updated successfully, but these errors were encountered: