-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to add system.memory.slab #531
Labels
Comments
Discussed on January 18th System Semantic Conventions WG meeting, we consider this a blocker since it affects the dimensions and metrics reported by the hostmetrics receiver. |
@rogercoll Could you file a PR for this? I think that makes sense to me indeed |
Sure, I'll file a PR for this. Thanks! |
3 tasks
ChrsMark
moved this from Todo
to In Progress
in System Semantic Convention Working Group
Jun 6, 2024
github-project-automation
bot
moved this from Needs Working Group
to Done
in Semantic Conventions + Instrumentation Stability WG
Jul 29, 2024
github-project-automation
bot
moved this from In Progress
to Done
in System Semantic Convention Working Group
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What are you trying to achieve?
At the moment, the assumption that the sum of all metrics states should be equal to the limit (or total) is broken for the Linux
system.memory
provided by the hostmetrics receiver. The issue is that Slab memory is included as a memory state.Related issues/PRs:
open-telemetry/opentelemetry-collector-contrib#14909
open-telemetry/opentelemetry-collector-contrib#7417
open-telemetry/opentelemetry-collector-contrib#19149
The proposed metric, "system.memory.slab", would track the amount of memory used by the kernel for Slab caching. This metric would be helpful for monitoring system memory usage on Linux-based systems, particularly in environments where Slab memory usage may be a significant contributor to overall memory usage.
Why not include it into system.memory? Because slab memory is already included in the
used
state provided by the receiver.What did you expect to see?
Additional context.
FreeBSD's systems uses a similar memory management technique called "uma" (Unified Memory Architecture), but I could not find the value on Gopsutils library, neither a generic name for all the systems. In Windows, the kernel uses a memory allocation technique called the "Non-paged pool" and the "Paged pool" to manage kernel memory.
Open to any other naming proposal, the most generic name I could think of to refer to Slab memory on any operating system is "object caching".
cc @rmfitzpatrick @dmitryax
The text was updated successfully, but these errors were encountered: