Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should client.port be changed to opt-in on HTTP server spans? #470

Closed
trask opened this issue Oct 29, 2023 · 0 comments · Fixed by #472
Closed

Should client.port be changed to opt-in on HTTP server spans? #470

trask opened this issue Oct 29, 2023 · 0 comments · Fixed by #472
Assignees
@reyang

Comments

@trask
Copy link
Member

trask commented Oct 29, 2023

It doesn't seem to have much value for a recommended attribute.

The only argument I can think of is for correlation with HTTP client spans, but client.port is already opt-in on HTTP client spans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyang reyang

Labels
None yet
Projects
Spec: HTTP Semantic Conventions
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change client.port from recommended to opt-in on HTTP server spans trask/semantic-conventions
2 participants
@trask @reyang