Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error.type - clarify how an exception type is represented #386

Closed
JamesNK opened this issue Oct 11, 2023 · 1 comment · Fixed by #387
Closed

error.type - clarify how an exception type is represented #386

JamesNK opened this issue Oct 11, 2023 · 1 comment · Fixed by #387
Assignees

Comments

@JamesNK
Copy link
Contributor

JamesNK commented Oct 11, 2023

error.type doesn't say how an exception should be represented.

I see that the logs spec says that exception.type should have the fully qualified class name (i.e. class name + namespace):

| `exception.type` | string | The type of the exception (its fully-qualified class name, if applicable). The dynamic type of the exception should be preferred over the static type in languages that support it. | `java.net.ConnectException`; `OSError` | See below |

error.type allows exception information to be set, but doesn't specify whether the type should be just the name or be fully qualified.

I think error.type definition should be updated to be more specific, like logging's exception.type.

Before:

**[1]:** If the request fails with an error before response status code was sent or received,
`error.type` SHOULD be set to exception type or a component-specific low cardinality error code.

After:

**[1]:** If the request fails with an error before response status code was sent or received,
`error.type` SHOULD be set to exception type (its fully-qualified class name, if applicable) or a component-specific low cardinality error code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants