Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define attributes to identify a CPU #130

Closed
3 tasks done
mx-psi opened this issue Jun 23, 2023 · 5 comments · Fixed by #337
Closed
3 tasks done

Define attributes to identify a CPU #130

mx-psi opened this issue Jun 23, 2023 · 5 comments · Fixed by #337
Assignees

Comments

@mx-psi
Copy link
Member

mx-psi commented Jun 23, 2023

CPUs allow users to fetch some identifying information about them. Similar to other system-level information such as the os.version, the host.arch or the kernel attributes proposed on #66, it can be helpful to have these kinds of attributes as part of the resource on OTLP payloads to identify and troubleshoot issues specific to a certain CPU model or its firmware version.

Many such identifying attributes can be found on Linux systems under the /proc/cpuinfo file. This issue would aim to identify the most important among them and create semantic conventions for them. In particular, at a minimum it seems like the following would be widely useful:

  • CPU Vendor ID (see CPUID)
  • CPU family, model, model name and stepping
  • CPU cache size and MHz

The following items would need to be addressed:

  • Decide if these should be resource level attributes or datapoint level attributes on the existing system.cpu.* metrics
  • Scope what attributes we consider important
  • Standardize the name of these attributes

This would be part of open-telemetry/opentelemetry-specification/issues/3556 if approved.

@ChrsMark
Copy link
Member

Hey @mx-psi are you planning to work on this? If not, I can work on this!

@mx-psi
Copy link
Member Author

mx-psi commented Jul 20, 2023

I am going to focus on other issues for now so feel free to work on this @ChrsMark!

@ChrsMark
Copy link
Member

ChrsMark commented Sep 7, 2023

Tasks:

@mx-psi is there any related issue for adding these in hostmetricsreceiver? I would like to give it a shot :).

@mx-psi
Copy link
Member Author

mx-psi commented Sep 7, 2023

is there any related issue for adding these in hostmetricsreceiver? I would like to give it a shot :).

No, but feel free to create one, I am happy to help there and review! I am not sure whether we want the resource attributes on hostmetricsreceiver or the resourcedetectionprocessor system detector. I would say probably system detector, since these attributes could be useful on any type of telemetry and not just on the cpu metrics, but we can discuss this on the Collector :)

@ChrsMark
Copy link
Member

ChrsMark commented Sep 14, 2023

Before moving to the cpu's frequency metrics we need to address #325 first since for the frequency we will need to report the core's ID along with the frequency metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants