Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric definitions for message/event networking (broker metrics) #120

Open
kmcclellan opened this issue Jun 18, 2023 · 3 comments
Open

Metric definitions for message/event networking (broker metrics) #120

kmcclellan opened this issue Jun 18, 2023 · 3 comments
Assignees

Comments

@kmcclellan
Copy link

I noticed there are semantic definitions for Kafka metrics, many of which could apply to other technologies that send messages/events over a network (AMQP, for example).

It seems valuable to define these metrics in way that is agnostic to technology/protocol, similar to the RPC metrics (in which there exists a similar overlap with HTTP).

@joaopgrassi
Copy link
Member

Hi @kmcclellan the messaging working group is tasked to work on "general" messaging metrics as part of the stabilization work. @lmolkova opened a draft PR with some ideas #163. Sorry this slipped and wasn't replied earlier. Let us know if you have other ideas and feel free to leave comments on the PR or join our SIG meetings.

@pyohannes
Copy link
Contributor

For a first stable version of messaging semantic conventions we will focus on client-side instrumentation (producer and consumer) of traces and metrics.

Broker instrumentation is something that will be tackled post-v1.

@kmcclellan
Copy link
Author

Makes sense, esp. given not all messaging protocols involve a "broker" role. Generally it might make sense to avoid Kafka-specific language for these semantics. "Publisher" and "subscriber" might serve better to that end (as opposed to "producer"/"consumer"). "Message" probably serves better than "event."

"Client" too may be worthy of avoidance, since pub/sub is quite a different paradigm than client/server (data flows in one direction instead of a bidirectional request/response).

On second thought, I better just take a look at the PR 🤠

@pyohannes pyohannes changed the title Metric definitions for message/event networking Metric definitions for message/event networking (broker metrics) Sep 14, 2023
@github-actions github-actions bot added the Stale label Feb 17, 2024
@joaopgrassi joaopgrassi removed the Stale label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Post-stability
Development

No branches or pull requests

4 participants