-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider http.status_code_class
attribute
#1056
Comments
I would prefer grouping starting with the first digit of the status code class. The httpcheck receiver in the collector currently reports |
I guess that would make more sense than making |
Hey @alanwest - I suggest you bring it to the Semantic Conventions SIG (every Monday after the maintainers meeting). |
@alanwest @codeboten @joaopgrassi please let us know if you think this should be considered as a blocker for HTTP semantic convention stability? my current assumption is that |
@trask I am not inclined to consider this a blocker for stability. I opened this issue based on open-telemetry/opentelemetry-specification#2943 (comment). @yurishkuro do you feel this should be a blocker? edit: just to expand a bit on why I do not think this is a blocker.. I personally think that a good default behavior is to include the full status code for metrics. For users who do experience cardinality issues due to status code, instrumentation might be able to be configured to turn off |
What is our general stance one such "trivially derivable" attributes? The http.status_code_class attribute will always be redundant with the (required) http.status_code. It seems conceptually useless to report this from the agent/client side already, but it might be useful in processing further down the line (maybe as soon as in some aggregating exporter in-process). I feel like this needs some more general discussion |
my thought also 👍 @Oberon00 do you think this needs more discussion before removing it as a blocker for HTTP semconv stability? |
Offering status_code_class as an alternative to status_code implies making status_code non-required (relaxing the condition). Wouldn't that be a breaking change? Just one example: backends may rely on presence of status_code to detect network errors, as discussed in open-telemetry/opentelemetry-specification#3253 |
ya, makes sense, as soon as you opt-out of I added a comment open-telemetry/opentelemetry-specification#3225 (comment) I see a couple of options:
|
We discussed this in the HTTP semconv meeting today. I have sent open-telemetry/opentelemetry-specification#3289 to clarify that
I think this gives the flexibility to make something like |
Inspired by open-telemetry/opentelemetry-specification#2943 (comment).
Proposal is to add a new attribute for grouping status codes by class, i.e.,
1xx
,2xx
,3xx
, etc. See: https://datatracker.ietf.org/doc/html/rfc9110#section-15.Open questions:
1xx
,2xx
, etc ORinformational
,successful
?http.status_code
become optional?The text was updated successfully, but these errors were encountered: