From de3900008d952ff6f5cbb22f922c859bda8423d5 Mon Sep 17 00:00:00 2001 From: maryliag Date: Thu, 2 May 2024 11:15:11 -0400 Subject: [PATCH] fix brief and change counter to gauge --- docs/attributes-registry/nodejs.md | 14 +++++++------- docs/runtime/nodejs-metrics.md | 6 +++--- model/metrics/nodejs-metrics.yaml | 4 ++-- model/registry/nodejs.yaml | 2 +- 4 files changed, 13 insertions(+), 13 deletions(-) diff --git a/docs/attributes-registry/nodejs.md b/docs/attributes-registry/nodejs.md index 596644c2ee..e8fb80ca60 100644 --- a/docs/attributes-registry/nodejs.md +++ b/docs/attributes-registry/nodejs.md @@ -10,13 +10,13 @@ Describes Node.js related attributes. -| Attribute | Type | Description | Examples | Stability | -| --------------------------- | ------ | ------------------------------- | ------------------------------- | ---------------------------------------------------------------- | -| `nodejs.eventloop.lag.type` | string | The type of memory. | `min`; `max`; `avg` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | -| `nodejs.gc.type` | string | The type of garbage collection. | `major`; `minor`; `incremental` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | -| `nodejs.memory.state` | string | The state of memory. | `total`; `used` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | -| `nodejs.memory.type` | string | The type of memory. | `heap`; `external` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | -| `nodejs.version` | string | Node.js version. | `v22.0.0`; `v21.7.3` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | +| Attribute | Type | Description | Examples | Stability | +| --------------------------- | ------ | ----------------------------------- | ------------------------------- | ---------------------------------------------------------------- | +| `nodejs.eventloop.lag.type` | string | The type of the event loop latency. | `min`; `max`; `avg` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | +| `nodejs.gc.type` | string | The type of garbage collection. | `major`; `minor`; `incremental` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | +| `nodejs.memory.state` | string | The state of memory. | `total`; `used` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | +| `nodejs.memory.type` | string | The type of memory. | `heap`; `external` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | +| `nodejs.version` | string | Node.js version. | `v22.0.0`; `v21.7.3` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | `nodejs.eventloop.lag.type` has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used. diff --git a/docs/runtime/nodejs-metrics.md b/docs/runtime/nodejs-metrics.md index b5dbc2d204..716f150746 100644 --- a/docs/runtime/nodejs-metrics.md +++ b/docs/runtime/nodejs-metrics.md @@ -66,13 +66,13 @@ This metric is [recommended][MetricRecommended]. | Name | Instrument Type | Unit (UCUM) | Description | Stability | | -------- | --------------- | ----------- | -------------- | --------- | -| `nodejs.eventloop.lag` | Counter | `s` | Event loop lag. | ![Experimental](https://img.shields.io/badge/-experimental-blue) | +| `nodejs.eventloop.lag` | Gauge | `s` | Event loop lag. | ![Experimental](https://img.shields.io/badge/-experimental-blue) | | Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | |---|---|---|---|---|---| -| [`nodejs.eventloop.lag.type`](/docs/attributes-registry/nodejs.md) | string | The type of memory. | `min`; `p90` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | +| [`nodejs.eventloop.lag.type`](/docs/attributes-registry/nodejs.md) | string | The type of the event loop latency. | `min`; `p90` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | | [`nodejs.version`](/docs/attributes-registry/nodejs.md) | string | Node.js version. | `v22.0.0`; `v21.7.3` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | `nodejs.eventloop.lag.type` has the following list of well-known values. If one of them applies, then the respective value MUST be used; otherwise, a custom value MAY be used. @@ -94,7 +94,7 @@ This metric is [recommended][MetricRecommended]. | Name | Instrument Type | Unit (UCUM) | Description | Stability | | -------- | --------------- | ----------- | -------------- | --------- | -| `nodejs.gc.duration` | Counter | `s` | Garbage collection duration. | ![Experimental](https://img.shields.io/badge/-experimental-blue) | +| `nodejs.gc.duration` | Gauge | `s` | Garbage collection duration. | ![Experimental](https://img.shields.io/badge/-experimental-blue) | diff --git a/model/metrics/nodejs-metrics.yaml b/model/metrics/nodejs-metrics.yaml index a600db8aa5..f57c05f2ef 100644 --- a/model/metrics/nodejs-metrics.yaml +++ b/model/metrics/nodejs-metrics.yaml @@ -25,7 +25,7 @@ groups: type: metric metric_name: nodejs.eventloop.lag brief: "Event loop lag." - instrument: counter + instrument: gauge unit: "s" stability: experimental prefix: nodejs.eventloop.lag @@ -39,7 +39,7 @@ groups: type: metric metric_name: nodejs.gc.duration brief: "Garbage collection duration." - instrument: counter + instrument: gauge unit: "s" stability: experimental prefix: nodejs.gc diff --git a/model/registry/nodejs.yaml b/model/registry/nodejs.yaml index bfdfdb6081..6989241602 100644 --- a/model/registry/nodejs.yaml +++ b/model/registry/nodejs.yaml @@ -38,7 +38,7 @@ groups: value: 'p99' brief: 'Event loop 99 percentile latency.' stability: experimental - brief: The type of memory. + brief: The type of the event loop latency. examples: ["min", "p90"] - id: gc.type stability: experimental