From d192f5981c6630d62d2ba54b43b4803ba8862b08 Mon Sep 17 00:00:00 2001 From: chengpu Date: Fri, 26 Apr 2024 09:01:27 +0800 Subject: [PATCH] Address comment problems --- docs/database/README.md | 1 + docs/database/influxdb.md | 6 +++--- model/trace/database.yaml | 4 ++-- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/docs/database/README.md b/docs/database/README.md index 6222376394..9a729ce6de 100644 --- a/docs/database/README.md +++ b/docs/database/README.md @@ -32,6 +32,7 @@ Technology specific semantic conventions are defined for the following databases * [CouchDB](couchdb.md): Semantic Conventions for *CouchDB*. * [Elasticsearch](elasticsearch.md): Semantic Conventions for *Elasticsearch*. * [HBase](hbase.md): Semantic Conventions for *HBase*. +* [InfluxDB](influxdb.md): Semantic Conventions for *InfluxDB*. * [MongoDB](mongodb.md): Semantic Conventions for *MongoDB*. * [MSSQL](mssql.md): Semantic Conventions for *MSSQL*. * [Redis](redis.md): Semantic Conventions for *Redis*. diff --git a/docs/database/influxdb.md b/docs/database/influxdb.md index 72f6e293e0..2c9c36d130 100644 --- a/docs/database/influxdb.md +++ b/docs/database/influxdb.md @@ -18,10 +18,10 @@ described on this page. | Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | |---|---|---|---|---|---| -| [`db.name`](../attributes-registry/db.md) | string | The InfluxDB database name. [1] | `mydb` | `Required` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | +| [`db.namespace`](../attributes-registry/db.md) | string | The InfluxDB database name. [1] | `mydb` | `Required` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | | [`db.operation.name`](../attributes-registry/db.md) | string | The name of the command being executed. [2] | `CREATE DATABASE`; `DROP DATABASE`; `SELECT`; `write` | `Required` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | -**[1]:** For InfluxDB the `db.name` should be set to the InfluxDB database name. +**[1]:** For InfluxDB the `db.namespace` should be set to the InfluxDB database name. **[2]:** See [InfluxDB database commands](https://docs.influxdata.com/influxdb/v1/query_language/). @@ -32,7 +32,7 @@ described on this page. |:--------------------|:----------------------------------| | Span name | `"SELECT mydb"` | | `db.system` | `"influxdb"` | -| `db.name` | `"mydb"` | +| `db.namespace` | `"mydb"` | | `server.address` | `"localhost"` | | `server.port` | `"32771"` | | `db.statement` | `"SELECT * FROM mydb GROUP BY *"` | diff --git a/model/trace/database.yaml b/model/trace/database.yaml index 7862bc88b6..eb5d030a69 100644 --- a/model/trace/database.yaml +++ b/model/trace/database.yaml @@ -351,10 +351,10 @@ groups: brief: > Attributes for InfluxDB attributes: - - ref: db.name + - ref: db.namespace brief: > The InfluxDB database name. - note: For InfluxDB the `db.name` should be set to the InfluxDB database name. + note: For InfluxDB the `db.namespace` should be set to the InfluxDB database name. examples: [ 'mydb' ] requirement_level: required tag: tech-specific