From 8ff4ea682198b41dad89c0484fee57c78777496f Mon Sep 17 00:00:00 2001 From: Trask Stalnaker Date: Tue, 31 Oct 2023 03:08:23 -0700 Subject: [PATCH] Make `client.address` sampling relevant on HTTP server spans (#469) Co-authored-by: Alexander Wert --- CHANGELOG.md | 2 ++ docs/http/http-spans.md | 1 + model/trace/http.yaml | 1 + 3 files changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f06b06560f..50adef6b59 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -46,6 +46,8 @@ release. - BREAKING: Make `url.scheme` opt_in for HTTP client and remove default value for `server.port` making it required on the client. ([#459](https://github.com/open-telemetry/semantic-conventions/pull/459)) +- Make `client.address` sampling relevant on HTTP server spans. + ([#469](https://github.com/open-telemetry/semantic-conventions/pull/469)) ### Features diff --git a/docs/http/http-spans.md b/docs/http/http-spans.md index 2c43c44788..6e2ba2f685 100644 --- a/docs/http/http-spans.md +++ b/docs/http/http-spans.md @@ -368,6 +368,7 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin Following attributes MUST be provided **at span creation time** (when provided at all), so they can be considered for sampling decisions: +* [`client.address`](../general/attributes.md) * [`server.address`](../general/attributes.md) * [`server.port`](../general/attributes.md) * [`url.path`](../attributes-registry/url.md) diff --git a/model/trace/http.yaml b/model/trace/http.yaml index e3da9342b6..7162eebf0e 100644 --- a/model/trace/http.yaml +++ b/model/trace/http.yaml @@ -65,6 +65,7 @@ groups: requirement_level: opt_in brief: Local socket port. Useful in case of a multi-port host. - ref: client.address + sampling_relevant: true note: > The IP address of the original client behind all proxies, if known (e.g. from [Forwarded#for](https://developer.mozilla.org/docs/Web/HTTP/Headers/Forwarded#for),