From 68ec7e2f79e94542012706808169dd7907047dba Mon Sep 17 00:00:00 2001 From: Liudmila Molkova Date: Wed, 13 Mar 2024 18:39:26 -0700 Subject: [PATCH] oops --- docs/attributes-registry/messaging.md | 4 ++-- model/registry/deprecated/messaging.yaml | 4 ++-- schema-next.yaml | 6 +++++- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/docs/attributes-registry/messaging.md b/docs/attributes-registry/messaging.md index 3d516ead81..beb0555c73 100644 --- a/docs/attributes-registry/messaging.md +++ b/docs/attributes-registry/messaging.md @@ -175,8 +175,8 @@ size should be used. | Attribute | Type | Description | Examples | Stability | |---|---|---|---|---| -| `kafka.consumer.group` | string | Deprecated, use `messaging.consumer.group.name` instead. | `my-group` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)
Replaced by `messaging.consumer.group.name`. | +| `messaging.kafka.consumer.group` | string | Deprecated, use `messaging.consumer.group.name` instead. | `my-group` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)
Replaced by `messaging.consumer.group.name`. | | `messaging.kafka.destination.partition` | int | Deprecated, use `messaging.destination.partition.id` instead. | `2` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)
Replaced by `messaging.destination.partition.id`. | | `messaging.operation` | string | Deprecated, use `messaging.operation.type` instead. | `publish`; `create`; `process` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)
Replaced by `messaging.operation.type`. | -| `rocketmq.client_group` | string | Deprecated, use `messaging.consumer.group.name` instead. | `myConsumerGroup` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)
Replaced by `messaging.consumer.group.name` on the consumer spans. No replacement for producer spans. | +| `messaging.rocketmq.client_group` | string | Deprecated, use `messaging.consumer.group.name` instead. | `myConsumerGroup` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)
Replaced by `messaging.consumer.group.name` on the consumer spans. No replacement for producer spans. | \ No newline at end of file diff --git a/model/registry/deprecated/messaging.yaml b/model/registry/deprecated/messaging.yaml index 98dab4bdb7..e313a43ae9 100644 --- a/model/registry/deprecated/messaging.yaml +++ b/model/registry/deprecated/messaging.yaml @@ -18,7 +18,7 @@ groups: Deprecated, use `messaging.operation.type` instead. examples: ["publish", "create", "process"] deprecated: "Replaced by `messaging.operation.type`." - - id: kafka.consumer.group + - id: messaging.kafka.consumer.group type: string brief: > Deprecated, use `messaging.consumer.group.name` instead. @@ -26,7 +26,7 @@ groups: Replaced by `messaging.consumer.group.name`. stability: experimental examples: 'my-group' - - id: rocketmq.client_group + - id: messaging.rocketmq.client_group type: string brief: > Deprecated, use `messaging.consumer.group.name` instead. diff --git a/schema-next.yaml b/schema-next.yaml index 512cd6d067..9953546f33 100644 --- a/schema-next.yaml +++ b/schema-next.yaml @@ -10,7 +10,11 @@ versions: state: db.client.connections.state apply_to_metrics: - db.client.connections.usage - # TODO + # https://github.com/open-telemetry/semantic-conventions/pull/815 + - rename_attributes: + attribute_map: + messaging.kafka.destination.partition: messaging.destination.partition.id + # https://github.com/open-telemetry/semantic-conventions/pull/815 - rename_attributes: attribute_map: messaging.kafka.consumer.group: messaging.consumer.group.name