From c7b094d36428ea7c7628533bfa4ab79fa153aa37 Mon Sep 17 00:00:00 2001 From: Anuraag Agrawal Date: Mon, 25 Sep 2023 23:44:03 +0900 Subject: [PATCH 1/3] Remove service.version from list of attributes with dedicated env var (#261) Co-authored-by: Josh Suereth Co-authored-by: Joao Grassi --- docs/resource/README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/resource/README.md b/docs/resource/README.md index 0426bd6249..c7637f565f 100644 --- a/docs/resource/README.md +++ b/docs/resource/README.md @@ -62,7 +62,6 @@ These are the attributes which MAY be configurable via a dedicated environment v as specified in [OpenTelemetry Environment Variable Specification](https://github.com/open-telemetry/opentelemetry-specification/tree/v1.22.0/specification/configuration/sdk-environment-variables.md): - [`service.name`](#service) -- [`service.version`](#service) ## Semantic Attributes with SDK-provided Default Value From 1d3d63b3d6ef85d658c96f463d44f33029de9cc7 Mon Sep 17 00:00:00 2001 From: Goutham Veeramachaneni Date: Mon, 25 Sep 2023 16:49:20 +0200 Subject: [PATCH 2/3] Update span name recommendation for HTTP Server (#287) Signed-off-by: Goutham Co-authored-by: Trask Stalnaker Co-authored-by: Johannes Tax Co-authored-by: Josh Suereth --- docs/http/http-spans.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/http/http-spans.md b/docs/http/http-spans.md index 914a859f0c..0449089215 100644 --- a/docs/http/http-spans.md +++ b/docs/http/http-spans.md @@ -368,10 +368,6 @@ This span type represents an inbound HTTP request. For an HTTP server span, `SpanKind` MUST be `Server`. -Given an inbound request for a route (e.g. `"/users/:userID?"`) the `name` attribute of the span SHOULD be set to this route. - -If the route cannot be determined, the `name` attribute MUST be set as defined in the general semantic conventions for HTTP. - | Attribute | Type | Description | Examples | Requirement Level | |---|---|---|---|---| From 984079ee2b98a5700b139989db9737b044ab40e6 Mon Sep 17 00:00:00 2001 From: Surbhi A <138259843+surbhiia@users.noreply.github.com> Date: Mon, 25 Sep 2023 07:56:22 -0700 Subject: [PATCH 3/3] Adding os.build_id resource attribute and discussion why os.sdk.version isn't required (#293) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Joao Grassi Co-authored-by: Christian Neumüller Co-authored-by: Joao Grassi Co-authored-by: Josh Suereth --- CHANGELOG.md | 2 ++ docs/resource/os.md | 1 + model/resource/os.yaml | 4 ++++ 3 files changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5dd4e7098a..613d3c8278 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -114,6 +114,8 @@ release. ([#296](https://github.com/open-telemetry/semantic-conventions/pull/296)) - Introducing Android `android.os.api_level` resource attribute. ([#328](https://github.com/open-telemetry/semantic-conventions/pull/328)) +- Added `os.build_id` resource attribute. + ([#293](https://github.com/open-telemetry/semantic-conventions/pull/293)) ## v1.21.0 (2023-07-13) diff --git a/docs/resource/os.md b/docs/resource/os.md index 2b73acea08..585c29d10c 100644 --- a/docs/resource/os.md +++ b/docs/resource/os.md @@ -15,6 +15,7 @@ In case of virtualized environments, this is the operating system as it is obser | `os.description` | string | Human readable (not intended to be parsed) OS version information, like e.g. reported by `ver` or `lsb_release -a` commands. | `Microsoft Windows [Version 10.0.18363.778]`; `Ubuntu 18.04.1 LTS` | Recommended | | `os.name` | string | Human readable operating system name. | `iOS`; `Android`; `Ubuntu` | Recommended | | `os.version` | string | The version string of the operating system as defined in [Version Attributes](/docs/resource/README.md#version-attributes). | `14.2.1`; `18.04.1` | Recommended | +| `os.build_id` | string | Unique identifier for a particular build or compilation of the operating system. | `TQ3C.230805.001.B2`; `20E247`; `22621` | Recommended | `os.type` has the following list of well-known values. If one of them applies, then the respective value MUST be used, otherwise a custom value MAY be used. diff --git a/model/resource/os.yaml b/model/resource/os.yaml index 083b88495e..78636f8461 100644 --- a/model/resource/os.yaml +++ b/model/resource/os.yaml @@ -63,3 +63,7 @@ groups: The version string of the operating system as defined in [Version Attributes](/docs/resource/README.md#version-attributes). examples: ['14.2.1', '18.04.1'] + - id: build_id + type: string + brief: 'Unique identifier for a particular build or compilation of the operating system.' + examples: ['TQ3C.230805.001.B2', '20E247', '22621']