From 50b741fe6f97cbc587dabdccce5159414e1c371a Mon Sep 17 00:00:00 2001 From: maryliag Date: Thu, 2 May 2024 16:34:25 -0400 Subject: [PATCH] add _libuv to active request metric name --- docs/runtime/nodejs-metrics.md | 10 +++++----- model/metrics/nodejs-metrics.yaml | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/runtime/nodejs-metrics.md b/docs/runtime/nodejs-metrics.md index 716f150746..7c65fc56f0 100644 --- a/docs/runtime/nodejs-metrics.md +++ b/docs/runtime/nodejs-metrics.md @@ -14,7 +14,7 @@ This document describes semantic conventions for Node.js metrics in OpenTelemetr - [Experimental](#experimental) - [Metric: `nodejs.active_handles.count`](#metric-nodejsactive_handlescount) - - [Metric: `nodejs.active_requests.count`](#metric-nodejsactive_requestscount) + - [Metric: `nodejs.active_libuv_requests.count`](#metric-nodejsactive_requestscount) - [Metric: `nodejs.eventloop.lag`](#metric-nodejseventlooplag) - [Metric: `nodejs.gc.duration`](#metric-nodejsgcduration) - [Metric: `nodejs.memory.size`](#metric-nodejsmemorysize) @@ -43,17 +43,17 @@ This metric is [recommended][MetricRecommended]. | [`nodejs.version`](/docs/attributes-registry/nodejs.md) | string | Node.js version. | `v22.0.0`; `v21.7.3` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | -### Metric: `nodejs.active_requests.count` +### Metric: `nodejs.active_libuv_requests.count` This metric is [recommended][MetricRecommended]. - + | Name | Instrument Type | Unit (UCUM) | Description | Stability | | -------- | --------------- | ----------- | -------------- | --------- | -| `nodejs.active_requests.count` | UpDownCounter | `{requests}` | Number of active requests. | ![Experimental](https://img.shields.io/badge/-experimental-blue) | +| `nodejs.active_libuv_requests.count` | UpDownCounter | `{requests}` | Number of active libuv requests. | ![Experimental](https://img.shields.io/badge/-experimental-blue) | - + | Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | |---|---|---|---|---|---| | [`nodejs.version`](/docs/attributes-registry/nodejs.md) | string | Node.js version. | `v22.0.0`; `v21.7.3` | `Recommended` | ![Experimental](https://img.shields.io/badge/-experimental-blue) | diff --git a/model/metrics/nodejs-metrics.yaml b/model/metrics/nodejs-metrics.yaml index f57c05f2ef..46d75797f5 100644 --- a/model/metrics/nodejs-metrics.yaml +++ b/model/metrics/nodejs-metrics.yaml @@ -10,10 +10,10 @@ groups: - ref: nodejs.version requirement_level: recommended - - id: metric.nodejs.active_requests.count + - id: metric.nodejs.active_libuv_requests.count type: metric - metric_name: nodejs.active_requests.count - brief: "Number of active requests." + metric_name: nodejs.active_libuv_requests.count + brief: "Number of active libuv requests." instrument: updowncounter unit: "{requests}" stability: experimental