From 3bd1c39e5f6aae7ea942c50bd771fa2e7e408249 Mon Sep 17 00:00:00 2001
From: Trask Stalnaker <trask.stalnaker@gmail.com>
Date: Wed, 16 Aug 2023 16:01:04 -0700
Subject: [PATCH] Rename `jvm.classes.current_loaded` to `jvm.classes.count`
 (#60)

---
 CHANGELOG.md                                   |  2 ++
 docs/system/runtime-environment-metrics.md     | 10 +++++-----
 model/metrics/process-runtime-jvm-metrics.yaml |  4 ++--
 schema-next.yaml                               |  3 ++-
 4 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a79fc4b3d6..054066f8fe 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -50,6 +50,8 @@ release.
   ([#249](https://github.com/open-telemetry/semantic-conventions/pull/249))
 - Add `jvm.cpu.count` metric.
   ([#52](https://github.com/open-telemetry/semantic-conventions/pull/52))
+- BREAKING: Rename `jvm.classes.current_loaded` metrics to `jvm.classes.count`
+  ([#60](https://github.com/open-telemetry/semantic-conventions/pull/60))
 
 ## v1.21.0 (2023-07-13)
 
diff --git a/docs/system/runtime-environment-metrics.md b/docs/system/runtime-environment-metrics.md
index b3c7b8cb88..e884bf5765 100644
--- a/docs/system/runtime-environment-metrics.md
+++ b/docs/system/runtime-environment-metrics.md
@@ -28,7 +28,7 @@ semantic conventions when instrumenting runtime environments.
   * [Metric: `jvm.threads.count`](#metric-jvmthreadscount)
   * [Metric: `jvm.classes.loaded`](#metric-jvmclassesloaded)
   * [Metric: `jvm.classes.unloaded`](#metric-jvmclassesunloaded)
-  * [Metric: `jvm.classes.current_loaded`](#metric-jvmclassescurrent_loaded)
+  * [Metric: `jvm.classes.count`](#metric-jvmclassescount)
   * [Metric: `jvm.cpu.time`](#metric-jvmcputime)
   * [Metric: `jvm.cpu.count`](#metric-jvmcpucount)
   * [Metric: `jvm.cpu.recent_utilization`](#metric-jvmcpurecent_utilization)
@@ -260,18 +260,18 @@ This metric is obtained from [`ClassLoadingMXBean#getUnloadedClassCount()`](http
 <!-- semconv metric.jvm.classes.unloaded(full) -->
 <!-- endsemconv -->
 
-### Metric: `jvm.classes.current_loaded`
+### Metric: `jvm.classes.count`
 
 This metric is [recommended][MetricRecommended].
 This metric is obtained from [`ClassLoadingMXBean#getLoadedClassCount()`](https://docs.oracle.com/javase/8/docs/api/java/lang/management/ClassLoadingMXBean.html#getLoadedClassCount--).
 
-<!-- semconv metric.jvm.classes.current_loaded(metric_table) -->
+<!-- semconv metric.jvm.classes.count(metric_table) -->
 | Name     | Instrument Type | Unit (UCUM) | Description    |
 | -------- | --------------- | ----------- | -------------- |
-| `jvm.classes.current_loaded` | UpDownCounter | `{class}` | Number of classes currently loaded. |
+| `jvm.classes.count` | UpDownCounter | `{class}` | Number of classes currently loaded. |
 <!-- endsemconv -->
 
-<!-- semconv metric.jvm.classes.current_loaded(full) -->
+<!-- semconv metric.jvm.classes.count(full) -->
 <!-- endsemconv -->
 
 ### Metric: `jvm.cpu.time`
diff --git a/model/metrics/process-runtime-jvm-metrics.yaml b/model/metrics/process-runtime-jvm-metrics.yaml
index 683b42ba92..5008665b6b 100644
--- a/model/metrics/process-runtime-jvm-metrics.yaml
+++ b/model/metrics/process-runtime-jvm-metrics.yaml
@@ -107,9 +107,9 @@ groups:
     instrument: counter
     unit: "{class}"
 
-  - id: metric.jvm.classes.current_loaded
+  - id: metric.jvm.classes.count
     type: metric
-    metric_name: jvm.classes.current_loaded
+    metric_name: jvm.classes.count
     brief: "Number of classes currently loaded."
     instrument: updowncounter
     unit: "{class}"
diff --git a/schema-next.yaml b/schema-next.yaml
index e19ff8a65e..bb558406e4 100644
--- a/schema-next.yaml
+++ b/schema-next.yaml
@@ -18,7 +18,8 @@ versions:
             process.runtime.jvm.threads.count: jvm.threads.count
             process.runtime.jvm.classes.loaded: jvm.classes.loaded
             process.runtime.jvm.classes.unloaded: jvm.classes.unloaded
-            process.runtime.jvm.classes.current_loaded: jvm.classes.current_loaded
+            # https://github.com/open-telemetry/semantic-conventions/pull/60
+            process.runtime.jvm.classes.current_loaded: jvm.classes.count
             process.runtime.jvm.cpu.time: jvm.cpu.time
             process.runtime.jvm.cpu.recent_utilization: jvm.cpu.recent_utilization
             process.runtime.jvm.memory.init: jvm.memory.init