From 2b29d7a77ff12aacd02f2306ccfddab83fbe0565 Mon Sep 17 00:00:00 2001 From: Liudmila Molkova Date: Wed, 13 Dec 2023 10:11:06 -0800 Subject: [PATCH] review comments --- model/registry/deprecated/http.yaml | 16 ++++++++-------- model/registry/deprecated/network.yaml | 22 +++++++++++----------- 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/model/registry/deprecated/http.yaml b/model/registry/deprecated/http.yaml index 22f0527721..9c255eb9f2 100644 --- a/model/registry/deprecated/http.yaml +++ b/model/registry/deprecated/http.yaml @@ -7,22 +7,22 @@ groups: - id: method type: string brief: 'Deprecated, use `http.request.method` instead.' - deprecated: "Renamed to `http.request.method`." + deprecated: "Replaced by `http.request.method`." examples: ["GET", "POST", "HEAD"] - id: status_code type: int brief: 'Deprecated, use `http.response.status_code` instead.' - deprecated: "Renamed to `http.response.status_code`." + deprecated: "Replaced by `http.response.status_code`." examples: [200] - id: scheme type: string brief: 'Deprecated, use `url.scheme` instead.' - deprecated: "Renamed to `url.scheme` instead." + deprecated: "Replaced by `url.scheme` instead." examples: ['http', 'https'] - id: url type: string brief: 'Deprecated, use `url.full` instead.' - deprecated: "Renamed to `url.full`." + deprecated: "Replaced by `url.full`." examples: ['https://www.foo.bar/search?q=OpenTelemetry#SemConv'] - id: target type: string @@ -32,12 +32,12 @@ groups: - id: request_content_length type: int brief: 'Deprecated, use `http.request.header.content-length` instead.' - deprecated: "Renamed to `http.request.header.content-length`." + deprecated: "Replaced by `http.request.header.content-length`." examples: 3495 - id: response_content_length type: int brief: 'Deprecated, use `http.response.header.content-length` instead.' - deprecated: "Renamed to `http.response.header.content-length`." + deprecated: "Replaced by `http.response.header.content-length`." examples: 3495 - id: flavor type: @@ -62,10 +62,10 @@ groups: value: 'QUIC' brief: 'QUIC protocol.' brief: 'Deprecated, use `network.protocol.name` instead.' - deprecated: "Renamed to `network.protocol.name`." + deprecated: "Replaced by `network.protocol.name`." - id: user_agent type: string brief: 'Deprecated, use `user_agent.original` instead.' examples: ['CERN-LineMode/2.15 libwww/2.17b3', 'Mozilla/5.0 (iPhone; CPU iPhone OS 14_7_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.2 Mobile/15E148 Safari/604.1'] - deprecated: "Renamed to `user_agent.original`." + deprecated: "Replaced by `user_agent.original`." diff --git a/model/registry/deprecated/network.yaml b/model/registry/deprecated/network.yaml index a502e68243..135373fa09 100644 --- a/model/registry/deprecated/network.yaml +++ b/model/registry/deprecated/network.yaml @@ -12,42 +12,42 @@ groups: examples: ['/var/my.sock'] - id: sock.peer.addr type: string - deprecated: "Renamed to `network.peer.address`." + deprecated: "Replaced by `network.peer.address`." brief: Deprecated, use `network.peer.address`. examples: ['192.168.0.1'] - id: sock.peer.port type: int - deprecated: "Renamed to `network.peer.port`." + deprecated: "Replaced by `network.peer.port`." examples: [65531] brief: Deprecated, use `network.peer.port`. - id: peer.name type: string - deprecated: "Renamed to `server.address` on client spans and `client.address` on server spans." + deprecated: "Replaced by `server.address` on client spans and `client.address` on server spans." brief: Deprecated, use `server.address` on client spans and `client.address` on server spans. examples: ['example.com'] - id: peer.port type: int - deprecated: "Renamed tp `server.port` on client spans and `client.port` on server spans." + deprecated: "Replaced by `server.port` on client spans and `client.port` on server spans." brief: Deprecated, use `server.port` on client spans and `client.port` on server spans. examples: [8080] - id: host.name type: string - deprecated: "Renamed to `server.address`." + deprecated: "Replaced by `server.address`." brief: Deprecated, use `server.address`. examples: ['example.com'] - id: host.port type: int - deprecated: "Renamed to `server.port`." + deprecated: "Replaced by `server.port`." brief: Deprecated, use `server.port`. examples: [8080] - id: sock.host.addr type: string - deprecated: "Renamed to `network.local.address`." + deprecated: "Replaced by `network.local.address`." brief: Deprecated, use `network.local.address`. examples: ['/var/my.sock'] - id: sock.host.port type: int - deprecated: "Renamed to `network.local.port`." + deprecated: "Replaced by `network.local.port`." brief: Deprecated, use `network.local.port`. examples: [8080] - id: transport @@ -71,16 +71,16 @@ groups: - id: other value: "other" brief: 'Something else (non IP-based).' - deprecated: "Renamed to `network.transport`." + deprecated: "Replaced by `network.transport`." brief: Deprecated, use `network.transport`. - id: protocol.name type: string - deprecated: "Renamed to `network.protocol.name`." + deprecated: "Replaced by `network.protocol.name`." brief: Deprecated, use `network.protocol.name`. examples: ['amqp', 'http', 'mqtt'] - id: protocol.version type: string - deprecated: "Renamed to `network.protocol.version`." + deprecated: "Replaced by `network.protocol.version`." brief: Deprecated, use `network.protocol.version`. examples: '3.1.1' - id: sock.family