Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

Remote write compliance: TestRemoteWrite/otelcollector/Counter #40

Closed
rakyll opened this issue Apr 20, 2021 · 2 comments · Fixed by open-telemetry/opentelemetry-collector#3047
Closed

Remote write compliance: TestRemoteWrite/otelcollector/Counter #40

rakyll opened this issue Apr 20, 2021 · 2 comments · Fixed by open-telemetry/opentelemetry-collector#3047
Labels
phase1 phase1 tasks prom-exporter Prometheus exporter tasks
Milestone
Phase 1 Implement...

Comments

@rakyll
Copy link
Contributor

rakyll commented Apr 20, 2021

The OpenTelemetry collector is not passing https://github.com/prometheus/compliance/tree/main/remote_write TestRemoteWrite/otelcollector/Counter.

=== CONT  TestRemoteWrite/otelcollector/Counter
    counter.go:35:
        	Error Trace:	counter.go:35
        	            				main_test.go:101
        	            				main_test.go:65
        	Error:      	Should be true
        	Test:       	TestRemoteWrite/otelcollector/Counter
        	Messages:   	found zero samples for {__name__="counter"}
@rakyll rakyll added phase1 phase1 tasks prom-exporter Prometheus exporter tasks labels Apr 20, 2021
@rakyll rakyll mentioned this issue Apr 20, 2021
Closed
@rakyll
Copy link
Contributor Author

rakyll commented Apr 21, 2021

Related to #43.

@Aneurysm9 Aneurysm9 mentioned this issue Apr 28, 2021
Merged
@alolita
Copy link
Member

alolita commented May 12, 2021

Blocked on PR 3047 in Collector; waiting to be merged.

@alolita alolita added the Blocked Waiting to be merged label May 12, 2021
@alolita alolita added this to the Phase 1 Implementation milestone Jun 18, 2021
@alolita alolita removed the Blocked Waiting to be merged label Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
phase1 phase1 tasks prom-exporter Prometheus exporter tasks
Projects
None yet
Milestone
Phase 1 Implementation
Development

Successfully merging a pull request may close this issue.

receiver/prometheus: Fix start timestamp adjustment logic Aneurysm9/opentelemetry-collector
2 participants
@rakyll @alolita