Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL schema files should be in a single repo #709

Closed
chalin opened this issue Sep 7, 2021 · 1 comment · Fixed by #715
Closed

OTEL schema files should be in a single repo #709

chalin opened this issue Sep 7, 2021 · 1 comment · Fixed by #715
Assignees
Labels

Comments

@chalin
Copy link
Contributor

chalin commented Sep 7, 2021

OTEL schema files are duplicated across this repo and opentelemetry-specification. Here's some more context for this issue:

The schema files should reside in a single repo (probably opentelemetry-specification). File copying across repos leads problems like the above, as well as those mentioned in #661, even if there is an action to sync (one way):

Disadvantages of file mirroring and copying:

  • We loose true edit/blame history
  • There's the risk of edits being done in the wrong place (since files are present in two repos)
  • There's potential confusion of where to open issues (again, since files are present in two repos)

In this case, I'd like to suggest bringing opentelemetry-specification/schemas into this repo via a submodule.

@austinlparker
Copy link
Member

Yeah, I concur that this should be a submodule. Could we continue to have push-button automation from the spec side in order to do the submodule update if that's how they're doing it now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants