Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Page feedback]: Divergence on Metrics Gauge definitions #5669

Closed
vitorvasc opened this issue Nov 22, 2024 · 4 comments
Closed

[Page feedback]: Divergence on Metrics Gauge definitions #5669

vitorvasc opened this issue Nov 22, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@vitorvasc
Copy link
Contributor

What needs to be changed?

Hi there! While contributing with the translation of the documents, I found a divergence on the English version of the Metrics Instruments definitions on the following pages:

What is the name + path of the page that needs changed?

docs/concepts/signals/metrics/#metric-instruments

Additional context: anything else you can think about that would be helpful.

By checking the Specs of the Metrics API, we can see Gauge and Asynchronous Gauge, so, I assume that the first page, the Concepts one, doesn't have the most recent version of these definitions.

@vitorvasc vitorvasc added the bug Something isn't working label Nov 22, 2024
@vitorvasc vitorvasc changed the title [Page Feedback]: Divergence on Metrics Gauge definitions [Page feedback]: Divergence on Metrics Gauge definitions Nov 22, 2024
@svrnm
Copy link
Member

svrnm commented Nov 25, 2024

good finding, @vitorvasc! Would you be interested in fixing that?

@vitorvasc
Copy link
Contributor Author

Thanks, @svrnm! Sorry for the delay here, been a busy week.

Sure! I'll create a new PR fixing this and will let you know as soon as possible.

cc @maryliag what we've been talking on Slack :)

@maryliag
Copy link
Contributor

discussed with Vitor offline and I took over. PR for all 3 existing languages of this page are now open

@svrnm
Copy link
Member

svrnm commented Dec 2, 2024

thank you @vitorvasc for reporting and @maryliag for fixing it (across 3 languages:-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants