Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] fix:text doesn't run the fix script #5647

Closed
chalin opened this issue Nov 20, 2024 · 1 comment · Fixed by #5648 or #5663
Closed

[CI] fix:text doesn't run the fix script #5647

chalin opened this issue Nov 20, 2024 · 1 comment · Fixed by #5648 or #5663
Assignees
Labels
CI/infra CI & infrastructure

Comments

@chalin
Copy link
Contributor

chalin commented Nov 20, 2024

Originally posted by @chalin in #5644 (comment):

fix:text was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

Oops, /fix:text doesn't actually run the fix script.

@chalin chalin added the CI/infra CI & infrastructure label Nov 20, 2024
@chalin chalin changed the title [CI] fix:text doesn't trigger a gh push [CI] fix:text doesn't run the fix script Nov 20, 2024
@chalin
Copy link
Contributor Author

chalin commented Nov 21, 2024

Reopening, since we need to install NPM packages before running fix:text, otherwise when installing it on the fly, it doesn't seem to find it's own config file, see: https://github.com/open-telemetry/opentelemetry.io/actions/runs/11948517767/job/33306251231#step:9:31

@chalin chalin reopened this Nov 21, 2024
@chalin chalin self-assigned this Nov 21, 2024
@github-project-automation github-project-automation bot moved this from Done to Need Docs Review in SIG Comms: PRs & Issues Nov 21, 2024
@github-project-automation github-project-automation bot moved this from Need Docs Review to Done in SIG Comms: PRs & Issues Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: Done
1 participant