Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Hugo 0.134+ -- possible breaking changes #5153

Closed
4 tasks done
Tracked by #5137
chalin opened this issue Sep 4, 2024 · 4 comments · Fixed by #5437
Closed
4 tasks done
Tracked by #5137

Upgrade to Hugo 0.134+ -- possible breaking changes #5153

chalin opened this issue Sep 4, 2024 · 4 comments · Fixed by #5437
Assignees
Labels
CI/infra CI & infrastructure

Comments

@chalin
Copy link
Contributor

chalin commented Sep 4, 2024

Note that we might be impacted by breaking changes. For release notes, see:

Tasks

@chalin chalin added the CI/infra CI & infrastructure label Sep 4, 2024
@svrnm
Copy link
Member

svrnm commented Sep 5, 2024

I quickly reviewed those changes, the only one that looks like we might be impacted are the alerts?

@chalin
Copy link
Contributor Author

chalin commented Sep 5, 2024

There might be an interplay with Docsy and Content summaries, given that they are now only processed as HTML. Something I'll be looking into on the Docsy side first, and then ensure that all is well here too (FYI).

@chalin chalin self-assigned this Sep 27, 2024
@chalin
Copy link
Contributor Author

chalin commented Sep 27, 2024

I can confirm that the value of the description attribute or element in the generated page headers changes. In some cases we actually get extra leading blanks. I'd suggest that we just ignore that for now.

Maybe more significant is the following issue, which I'll wait to get feedback on before upgrading Hugo:

@chalin
Copy link
Contributor Author

chalin commented Oct 2, 2024

Also hoping that the following will be addressed / accepted:

@chalin chalin changed the title Upgrade to Hugo 0.134.x -- possible breaking changes Upgrade to Hugo 0.134+ -- possible breaking changes Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants