Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt-br] Localize 'sampling' page to Portuguese (Brazil) #5138

Merged

Conversation

lopes-felipe
Copy link
Member

Issue: #4922

@lopes-felipe lopes-felipe requested a review from a team September 2, 2024 23:15
@opentelemetrybot opentelemetrybot requested review from a team September 2, 2024 23:17
@edsoncelio edsoncelio mentioned this pull request Sep 3, 2024
26 tasks
Copy link
Contributor

@janssenlima janssenlima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ótimo trabalho. Deixei algumas coisas para revisão.

content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested a review from a team September 3, 2024 13:59
lopes-felipe and others added 16 commits September 3, 2024 10:59
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito bom, parabéns @lopes-felipe!

content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
Comment on lines 106 to 108
## Amostragem de Cabeça

A amostragem de cabeça é uma técnica de amostragem usada para tomar uma decisão
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Amostragem de Cabeça
A amostragem de cabeça é uma técnica de amostragem usada para tomar uma decisão
## Amostragem pela cabeça
A amostragem pela cabeça (_head sampling_) é uma técnica de amostragem usada para tomar uma decisão

Eu não conhecia esse termo. Parece ser bastante utilizado no contexto do OpenTelemetry (a Grafana e a Honeycomb também usam) mas não encontrei nenhuma tradução.

"Pela cabeça" me parece mais próxima do sentido original, já que dá um senso de direção: a decisão de sampling é feita pelo início dos rastros. "De cabeça" parece que a cabeça está sendo amostrada 😅

Mas as duas opções me soam um pouco estranho, então não tenho muita preferência.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boa, pensando agora acho que também prefiro "pela cabeça" ao invés de "de cabeça", mas vamos ver o que as outras pessoas tem a dizer :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outra opção seria um termo diferente, por exemplo "Amostragem pelo começo" e "amostragem pelo final". Isso estaria mais próximo de conceitos como começo e final de uma fila ou lista (list head/tail).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A segunda sugestão do Luís (amostragem pelo começo/pelo final) soa melhor ao invés de cabeça e calda rsrsrsrs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fui com "pela cabeça/cauda" porque sinto que correlaciona melhor com o conceito original (head/tail) que é mais bem difundido :)
9a6192c

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me parece fazer sentido algo como começo/final ou antecipada/tardia, mas eu acho que cabeça/cauda da pra bater o olho e saber tbm do q se trata, n tenho uma opinião forte aqui

content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/sampling/index.md Outdated Show resolved Hide resolved
@lopes-felipe
Copy link
Member Author

Valeu pelos reviews @EzzioMoreira e @lgfa29!

@EzzioMoreira
Copy link
Contributor

Parabéns pelo trabalho 👏👏👏

@EzzioMoreira
Copy link
Contributor

LGTM!!!!!

@theletterf theletterf enabled auto-merge September 8, 2024 14:02
@theletterf theletterf added this pull request to the merge queue Sep 8, 2024
@opentelemetrybot opentelemetrybot requested a review from a team September 8, 2024 16:29
Merged via the queue into open-telemetry:main with commit e71e88b Sep 8, 2024
14 of 15 checks passed
@lopes-felipe lopes-felipe deleted the localization/pt-br/sampling branch September 8, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants