Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong PrometheusHttpServer link in js exporters documentation #5018

Closed
chenlujjj opened this issue Aug 10, 2024 · 3 comments · Fixed by #5038
Closed

Wrong PrometheusHttpServer link in js exporters documentation #5018

chenlujjj opened this issue Aug 10, 2024 · 3 comments · Fixed by #5038

Comments

@chenlujjj
Copy link

In the doc, https://opentelemetry.io/docs/languages/js/exporters/#prometheus, the PrometheusHttpServer points to a javadoc web page. I think it's a mistake.

image

@theletterf
Copy link
Member

Thanks @chenlujjj. That seems to be a mistake, yes. Do you happen to know what the right page should be? @open-telemetry/javascript-approvers ?

@chenlujjj
Copy link
Author

@theletterf I think it should be https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-exporter-prometheus

@svrnm
Copy link
Member

svrnm commented Aug 12, 2024

To stay consistent with other languages and pages, I recommend linking to the JS API/SDK docs @ https://open-telemetry.github.io/opentelemetry-js/classes/_opentelemetry_exporter_prometheus.PrometheusExporter.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants