Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Collector internal metric names by version #4933

Closed
tiffany76 opened this issue Aug 1, 2024 · 6 comments · Fixed by #5178
Closed

Clarify Collector internal metric names by version #4933

tiffany76 opened this issue Aug 1, 2024 · 6 comments · Fixed by #5178
Labels
bug Something isn't working good first issue Good for newcomers sig:collector

Comments

@tiffany76
Copy link
Contributor

What needs to be changed? With release v0.106.1, the names of Collector internal metrics are handled differently, depending on whether they are generated from Collector components (prefixed with otelcol_) or instrumentation libraries (not prefixed with otelcol_).

The list of metrics is correct as-is, but we should add a note that clarifies that versions of the Collector prior to v0.106.1 append the otelcol_ prefix to all internal metrics, both instrumentation library-generated as well as component-generated.

What is the name + path of the page that needs changed? https://opentelemetry.io/docs/collector/internal-telemetry/#lists-of-internal-metrics

Additional context: See comment.

@Tharanishwaran
Copy link
Contributor

Hi, I’d like to work on this issue if it’s still available.can i work on this issue ?

@tiffany76
Copy link
Contributor Author

Hi @Tharanishwaran! Thanks for volunteering! This issue is all yours. Please go ahead and put up a PR for review.

Let us know if you have any questions. And thanks again!

@Tharanishwaran
Copy link
Contributor

Hi @tiffany76 ,Thanks for assigning this to me! I'll get started and will put up a PR soon. If I have any questions along the way, I'll be sure to reach out.

Thanks again!

@tiffany76
Copy link
Contributor Author

Hi @Tharanishwaran - have you had a chance to work on this issue? If so, please put up a draft PR so we can give you feedback. Thanks!

@Tharanishwaran
Copy link
Contributor

Hi @tiffany76 ,
I’ve been dealing with some health issues, which have delayed my work on this issue. I’m currently working on it and will update you soon.
Thanks for your understanding!

@Tharanishwaran
Copy link
Contributor

Hi @tiffany76 I see this pull request #5178 is not yet merged. Should there be anything to do more, or some issues still need to be fixed? I will be glad to fix those issues

@github-project-automation github-project-automation bot moved this from Need SIG Review to Done in SIG Comms: PRs & Issues Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers sig:collector
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants