-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ja] add: translation of contributing #4780
Conversation
87ff35c
to
db4854b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I left some comments and I'd like to hear your thoughts on those.
|
||
OpenTelemetryプロジェクトへの一般的なコントリビュートの手引には、[OpenTelemetryコントリビュートガイド](https://github.com/open-telemetry/community/blob/main/CONTRIBUTING.md) | ||
を参照ください。 | ||
コントリビュートライセンス規約(Contributor License Agreement)と行動規範(Code of Conduct)の詳細が記されています。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is just a confirmation, but is it common to translate "Contributor" to "コントリビュート"? I see that consistency in your translation, I'm wondering which is better to translate "コントリビュート" or "コントリビューター" here, though the impressions of both translation give are mostly same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo for the コントリビュートライセンス規約. I fixed it to コントリビューターライセンス規約 to match the original text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the doc linked is named "OpenTelemetry Contributor Guide" so I fixed here. otherwise, all LGTM, so I'll approve this PR as soon as the suggestion is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Yoshi Yamaguchi <[email protected]>
80f10ae
to
7a8c69e
Compare
Thank you @kaitoii11 ! |
translate
content/docs/contributing/_index.md
to Japanese.r