Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] add: translation of contributing #4780

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

kaitoii11
Copy link
Contributor

translate content/docs/contributing/_index.md to Japanese.r

@kaitoii11 kaitoii11 requested review from a team July 2, 2024 14:52
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I left some comments and I'd like to hear your thoughts on those.

content/ja/docs/contributing/_index.md Outdated Show resolved Hide resolved

OpenTelemetryプロジェクトへの一般的なコントリビュートの手引には、[OpenTelemetryコントリビュートガイド](https://github.com/open-telemetry/community/blob/main/CONTRIBUTING.md)
を参照ください。
コントリビュートライセンス規約(Contributor License Agreement)と行動規範(Code of Conduct)の詳細が記されています。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just a confirmation, but is it common to translate "Contributor" to "コントリビュート"? I see that consistency in your translation, I'm wondering which is better to translate "コントリビュート" or "コントリビューター" here, though the impressions of both translation give are mostly same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo for the コントリビュートライセンス規約. I fixed it to コントリビューターライセンス規約 to match the original text.

@chalin chalin force-pushed the ja-contributing branch from f09d2db to 98b0875 Compare July 3, 2024 17:42
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the doc linked is named "OpenTelemetry Contributor Guide" so I fixed here. otherwise, all LGTM, so I'll approve this PR as soon as the suggestion is merged.

content/ja/docs/contributing/_index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svrnm
Copy link
Member

svrnm commented Jul 5, 2024

Thank you @kaitoii11 !

@svrnm svrnm merged commit fa5e2bf into open-telemetry:main Jul 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants