-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create documentation for running the OTel Demo on GitHub Codespaces #4725
Comments
thanks @avillela, as you know I always prefer more docs over having blog posts;-) but in that particular case I wonder more about GH codespaces being a commercial solution how well that goes with our social media guide. I might be overly paranoid here, especially sing codespaces is not an o11y product, but I wanted to call that out. I would enjoy reading such a blog post (or docs page), but I am conflicted on that. @open-telemetry/demo-approvers @open-telemetry/docs-approvers, wdyt? |
I'm not even sure it works, but getting the otel-demo to work in a dev container environment and using GitHub Codespaces as an example in a blog post would be okay. |
I did get it running a few weeks back in GH Codespaces - had to beef up the container specs to get it to work and get the various UIs to run 😁 |
I'd be okay with it, but as @svrnm mentioned, I believe we should try to keep it as agnostic as possible. Mastodon project has the The blog/doc could focus on running the demo locally, and if people want to run in Codespaces, they could use the same config, but we as community do not "advertise" it. WDYT? |
+1 to getting a proper |
Not an expert on the matter, but if there is an OSS solution under codespaces we could support officially that would be my favourite solution. |
I definitely like the idea @julianocosta89. I can explore a pure devcontainer solution a bit further. Stay tuned! |
Okay...I created a |
@avillela I've tried it on my M1 and got the following error:
Have you faced something similar? |
@julianocosta89 Do you get this error when starting up the devcontainer locally? The issue I've had is that ARM images aren't supported by devcontainers, so the workaround is to first pull the amd64 version of the base image manually before trying to run the devcontainer: docker pull --platform linux/amd64 mcr.microsoft.com/devcontainers/base:ubuntu I've tested this successfully in:
Also, I had to tweak the |
@avillela awesome! It works great! QQ as we are at it, do we want to focus on the |
Doing some tests, I've just noticed that OpenSearch doesn't start 😢
As it doesn't start, we do not get logs in Grafana. |
@julianocosta89 to answer your other question, we could definitely expand the Dev Container to enable development as well. It would certainly lower the barrier to contribution. |
@julianocosta89 another thing to add...so I ran a bunch of tests today, and it does look like eventually I end up getting various IO errors which means that logs aren't always getting through. I spent a ton of time trying to search for a culprit but didn't have any luck. I think it may either be because the devcontainer specs aren't beefy enough (GH codespaces lets me have a max of 4 cores and 16GB RAM, and my own local Docker is restricted at 3 cores and 9GB RAM). Another possibility may be related to the fact that we're running Docker in Docker. Any thoughts? |
Latest update. I have a new version of the dev container pushed. I based it off of the "Blank" image in GitHub Codespaces that I used for my original pre-devcontainer experiment. It basically includes additional features. I ran a couple of tests and I'm not seeing the weird timeouts that I was seeing before. It also incldues various language runtimes, so we could technically use it as a dev environment too. |
That looks great @avillela! The OpenSearch local issue is still ongoing though 😭 Maybe we need to configure |
@julianocosta89 to confirm - the OpenSearch issue happens when running locally but not in Codespaces? |
@avillela I haven't tried in codespaces, just locally |
@julianocosta89 I'd be curious to see what happens locally. Also, you're not seeing any logs on your end in Grafana then (assuming that's the case because of the error you're getting)? I only ask because I don't see that error locally on my end. I did a search on the error string that you posted above, and nothing comes up for me. And I can see the logs, both when I locally and remote (GH Codespaces). |
@avillela maybe it is an issue on Mac 🙃 In which OS are you running the demo? |
I'm running MacOS Sonoma 14.5, and Docker 24.0.2 |
I'm on Docker version: 24.0.7 🙃 |
One more question - what resources did you dedicate to Docker? I allocated 3 CPUs and 9GB RAM. And are you running anything else in Docker at the same time? It's a beefy image. 🙃 |
Nope, just testing the devcontainer and starting the demo ofc. I have 10 CPUs and 32GB RAM allocated for Docker, what is extremely high 😅 |
I'm out of ideas. I'm so confused. Can you try to run it remotely in GH Codespaces? Just curious to see what happens. |
Also, would you be open to pairing on this? I'm out until August 12th, so sometime that week? |
One other thing that came to mind. Have to tried clearing all of your existing Docker images and volumes to make sure that nothing has been cached? |
@avillela I'll try the codespaces later this week. When you are back, I'll be out 🙃 |
Ping me when you get back and we'll set something up! |
@avillela I've tested the devcontainer today and it worked! 🥳 |
for some reason Another thing that I'm noticing is that for some reason |
Out of curiosity, is this when running the dev container locally or in GH Codespaces? |
devcontainer locally |
I think that it would be helpful to the community to have documentation on running the OTel Demo using GitHub Codespaces. We can do it in one of two ways:
Thoughts??
The text was updated successfully, but these errors were encountered: