New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry code-block styling workaround is incompatible with dark mode #4389

Closed

Tracked by

chalin opened this issue Apr 29, 2024 · 0 comments · Fixed by #4390

Closed

Tracked by

Registry code-block styling workaround is incompatible with dark mode #4389

chalin opened this issue Apr 29, 2024 · 0 comments · Fixed by #4390

Assignees

Labels

e0-minutes e1-hours p1-high

Contributor

chalin commented Apr 29, 2024

Registry Refresher: UI changes, search updates & more #3730 introduced a temporary workaround to enable code-block syntax highlighting to work, namely these lines: https://github.com/open-telemetry/opentelemetry.io/blame/07a4f5559c7d4286a7f95b0aae8b5312e45e797a/assets/scss/_registry.scss#L43-L69
The workaround was meant to be temporary, and it's an obstacle to dark mode support.

chalin added e0-minutes e1-hours p1-high labels

chalin self-assigned this

This was referenced Apr 29, 2024

Dark mode #4023

Closed

Remove temp registry .highlight style override #4390

Merged

chalin closed this as completed in #4390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment