Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove processor from glossary #3895

Closed
cijothomas opened this issue Jan 30, 2024 · 9 comments
Closed

Remove processor from glossary #3895

cijothomas opened this issue Jan 30, 2024 · 9 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@cijothomas
Copy link
Member

https://opentelemetry.io/docs/concepts/glossary/#processor talks about Instrumentation Library, but not sure what is the connection between Instrumentation Library and processor here....

@cijothomas
Copy link
Member Author

It may be better to remove it, as it is a collector specific term. (There are other processors like spanprocessor/logrecordprocessor, but not in the glossary, and don't think we should have it for the processor in the collector in the main glossary).

@svrnm
Copy link
Member

svrnm commented Jan 30, 2024

Thanks for calling this out. We had a few places in the past already that mixed instrumentation libraries with other components (here I would say it's language specific SDK)

Feel free to raise a PR

@theletterf
Copy link
Member

@cijothomas Will you open the PR? Thanks!

@svrnm svrnm changed the title https://opentelemetry.io/docs/concepts/glossary/#processor Remove processor from glossary Apr 16, 2024
@svrnm svrnm added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Apr 16, 2024
@IrisDyr
Copy link

IrisDyr commented Apr 16, 2024

Hello,
I would love to help out with this one

@svrnm
Copy link
Member

svrnm commented Apr 16, 2024

@IrisDyr awesome! Just go ahead and raise a PR:-)

@ricardoamaro
Copy link
Contributor

ricardoamaro commented Apr 16, 2024

PR created here: #4307

@svrnm
Copy link
Member

svrnm commented Apr 16, 2024

@ricardoamaro please look above that @IrisDyr asked to pick this first and we should give people some time to provide their PR after volunteering. This is a trivial change, but I want to be respectful here. @IrisDyr please let us know if you are OK with us merging @ricardoamaro's PR.

@IrisDyr
Copy link

IrisDyr commented Apr 16, 2024

It's okay for me to merge it. Thank you @svrnm

@ricardoamaro
Copy link
Contributor

Thank you, @IrisDyr 👍🏽! I would also be ok waiting more. Taking the opportunity here to learn the ropes :)

@svrnm svrnm closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants