Fix typos in "Signals" documentation section #3825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Thanks for the fixes @fabrideci. We'll need you to sign the CLA before we can merge this.
| @@ -298,7 +298,7 @@ Each span has a status. The three possible values are: | |||
| The default value is `Unset`. A span status that is `Unset` means that the | |||
| operation it tracked successfully completed without an error. | |||
|
|
|||
| When a span status is `Error`, then that means some error ocurred in the | |||
There was a problem hiding this comment.
@svrnm - we should find out why cSpell doesn't detect this. I made some quick tests but wasn't able to find out why. Maybe a bug with the its dictionary?
There was a problem hiding this comment.
that's odd indeed, they even have it here:
There was a problem hiding this comment.
There was a problem hiding this comment.
raised an issue: streetsidesoftware/cspell-dicts#2940
theletterf
approved these changes
Jan 19, 2024
cartermp
approved these changes
Jan 20, 2024
jaydeluca
pushed a commit
to jaydeluca/opentelemetry.io
that referenced
this pull request
Jan 31, 2024
Co-authored-by: Phillip Carter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the code required to fix two simple typos in the "Logs" and "Traces" pages of the "Concept - Signals" documentation section.