Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CVE page #3659

Merged
merged 11 commits into from
Dec 10, 2023
Merged

Add CVE page #3659

merged 11 commits into from
Dec 10, 2023

Conversation

martinkuba
Copy link
Contributor

This is adding a page with a list of published security vulnerabilities across all repositories, similar to Kubernetes docs.

@martinkuba martinkuba requested a review from a team December 8, 2023 00:19
svrnm
svrnm reviewed Dec 8, 2023
View reviewed changes
content/en/docs/cve.md Outdated Show resolved Hide resolved
svrnm
svrnm previously requested changes Dec 8, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to have this, I provided some initial feedback

content/en/docs/cve.md Outdated Show resolved Hide resolved
content/en/docs/cve.md Outdated Show resolved Hide resolved
chalin
chalin reviewed Dec 8, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both points that @svrnm raised: let's move this into the newly proposed /security section, and do data-fetch at build time.

chalin
chalin reviewed Dec 8, 2023
View reviewed changes
content/en/docs/cve.md Outdated Show resolved Hide resolved
@chalin
Copy link
Contributor

chalin commented Dec 8, 2023

Otherwise, great job! LGTM

@cartermp cartermp merged commit 95e83ad into open-telemetry:main Dec 10, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin left review comments

@cartermp cartermp cartermp approved these changes

@theletterf theletterf theletterf approved these changes

@svrnm svrnm svrnm left review comments

Assignees
No one assigned
Labels
sig:security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martinkuba @chalin @svrnm @theletterf @cartermp