-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog post about adopting OTel metrics in Cloud Foundry #3466
Add blog post about adopting OTel metrics in Cloud Foundry #3466
Conversation
|
Very cool! Welcome and thanks for the contribution. I'll drop a few initial copyedit comments shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few quick drive-by copyedit comments.
0f68a63
to
4de7866
Compare
4de7866
to
ac62d8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm in general. We'll probably want to copy over the boiler plate integration heading from the Tyk blog cc @svrnm @austinlparker
ac62d8d
to
e55086a
Compare
5544bd5
to
d5de1dd
Compare
d5de1dd
to
911450c
Compare
0b2d5ae
to
4413d42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall, some suggestions to add links to different internal pages and one major change request around the decision process.
5cfdd61
to
9b016f1
Compare
@ctlong remember to update the branch too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@ctlong you have disabled that maintainers can add commits to your PR, so please fix the formatting by running npm run format
and push the updates to this
9b016f1
to
adcdf52
Compare
@ctlong please update the branch once again such that we are able to merge |
This blog post details an experience report for adopting OTel for metrics in Cloud Foundry. Co-authored-by: Carson Long <[email protected]>
Replace OTel Community alert with new badge Co-authored-by: Patrice Chalin <[email protected]>
Update date Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
Fix formatting.
b3bc48d
to
c902257
Compare
@svrnm done!
My bad. I definitely didn't intend to disable that feature. Now it appears I can't change it without recreating the PR. If we keep running into rebase problems I can try recreating it with the feature enabled. |
This is our first time contributing to the OTel blog. Excited to hear your feedback!
Preview: https://deploy-preview-3466--opentelemetry.netlify.app/blog/2023/cloud-foundry/