Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog post about adopting OTel metrics in Cloud Foundry #3466

Conversation

ctlong
Copy link
Contributor

@ctlong ctlong commented Oct 31, 2023

This is our first time contributing to the OTel blog. Excited to hear your feedback!


Preview: https://deploy-preview-3466--opentelemetry.netlify.app/blog/2023/cloud-foundry/

@ctlong ctlong requested review from a team October 31, 2023 22:34
Copy link

linux-foundation-easycla bot commented Oct 31, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@chalin
Copy link
Contributor

chalin commented Oct 31, 2023

Very cool! Welcome and thanks for the contribution. I'll drop a few initial copyedit comments shortly.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few quick drive-by copyedit comments.

@ctlong ctlong force-pushed the blog/adopting-otel-metrics-in-cloud-foundry branch from 0f68a63 to 4de7866 Compare October 31, 2023 23:14
@mkocher mkocher force-pushed the blog/adopting-otel-metrics-in-cloud-foundry branch from 4de7866 to ac62d8d Compare October 31, 2023 23:41
Copy link
Contributor

@cartersocha cartersocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm in general. We'll probably want to copy over the boiler plate integration heading from the Tyk blog cc @svrnm @austinlparker

@ctlong ctlong force-pushed the blog/adopting-otel-metrics-in-cloud-foundry branch from ac62d8d to e55086a Compare November 1, 2023 19:09
chalin
chalin previously requested changes Nov 1, 2023
content/en/blog/2023/cloud-foundry.md Outdated Show resolved Hide resolved
@ctlong ctlong force-pushed the blog/adopting-otel-metrics-in-cloud-foundry branch 2 times, most recently from 5544bd5 to d5de1dd Compare November 2, 2023 21:27
@ctlong ctlong force-pushed the blog/adopting-otel-metrics-in-cloud-foundry branch from d5de1dd to 911450c Compare November 6, 2023 16:15
@ctlong ctlong requested a review from chalin November 6, 2023 16:17
@chalin
Copy link
Contributor

chalin commented Nov 6, 2023

Thanks for adding the badge.
I'll let @svrnm review the content as a blog approver.

@svrnm - On a technical note, we can merge this before 11/08, unless we revisit the date of the Integration blog to be whenever this post gets published.

@ctlong ctlong force-pushed the blog/adopting-otel-metrics-in-cloud-foundry branch from 0b2d5ae to 4413d42 Compare November 6, 2023 21:00
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, some suggestions to add links to different internal pages and one major change request around the decision process.

content/en/blog/2023/cloud-foundry.md Outdated Show resolved Hide resolved
content/en/blog/2023/cloud-foundry.md Outdated Show resolved Hide resolved
content/en/blog/2023/cloud-foundry.md Outdated Show resolved Hide resolved
content/en/blog/2023/cloud-foundry.md Outdated Show resolved Hide resolved
content/en/blog/2023/cloud-foundry.md Outdated Show resolved Hide resolved
content/en/blog/2023/cloud-foundry.md Outdated Show resolved Hide resolved
content/en/blog/2023/cloud-foundry.md Outdated Show resolved Hide resolved
content/en/blog/2023/cloud-foundry.md Outdated Show resolved Hide resolved
@ctlong ctlong force-pushed the blog/adopting-otel-metrics-in-cloud-foundry branch from 5cfdd61 to 9b016f1 Compare November 7, 2023 22:36
@ctlong ctlong requested a review from svrnm November 7, 2023 22:37
@cartersocha
Copy link
Contributor

@ctlong remember to update the branch too!

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@ctlong you have disabled that maintainers can add commits to your PR, so please fix the formatting by running npm run format and push the updates to this

@ctlong ctlong force-pushed the blog/adopting-otel-metrics-in-cloud-foundry branch from 9b016f1 to adcdf52 Compare November 8, 2023 15:52
@svrnm
Copy link
Member

svrnm commented Nov 8, 2023

@ctlong please update the branch once again such that we are able to merge

mkocher and others added 4 commits November 8, 2023 14:34
This blog post details an experience report for adopting OTel for
metrics in Cloud Foundry.

Co-authored-by: Carson Long <[email protected]>
Replace OTel Community alert with new badge

Co-authored-by: Patrice Chalin <[email protected]>
@ctlong ctlong force-pushed the blog/adopting-otel-metrics-in-cloud-foundry branch from b3bc48d to c902257 Compare November 8, 2023 20:34
@ctlong
Copy link
Contributor Author

ctlong commented Nov 8, 2023

@ctlong please update the branch once again such that we are able to merge

@svrnm done!

@ctlong you have disabled that maintainers can add commits to your PR.

My bad. I definitely didn't intend to disable that feature. Now it appears I can't change it without recreating the PR. If we keep running into rebase problems I can try recreating it with the feature enabled.

@svrnm svrnm merged commit d63ad33 into open-telemetry:main Nov 8, 2023
12 checks passed
@ctlong ctlong deleted the blog/adopting-otel-metrics-in-cloud-foundry branch November 9, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants