Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Document environment variables in Sampling #3325

Closed
10 tasks
pellared opened this issue Sep 28, 2023 · 7 comments
Closed
10 tasks

[meta] Document environment variables in Sampling #3325

pellared opened this issue Sep 28, 2023 · 7 comments
Labels
0-meta docs help wanted Extra attention is needed

Comments

@pellared
Copy link
Member

pellared commented Sep 28, 2023

I think we should also document setting the environment variable in a top-level section in this guide. That can be especially helpful for development since you can just use the default, but then have production do something different.

Originally posted by @cartermp in #3318 (review)

Also #3318 (comment)


(edit by @svrnm)

Tracking:

  • C++
  • .NET
  • Erlang/Elixir
  • Java
  • JavaScript
  • PHP
  • Python
  • Ruby
  • Rust
  • Swift
@pellared
Copy link
Member Author

@svrnm
Copy link
Member

svrnm commented Sep 29, 2023

is this only a go thing?

@pellared
Copy link
Member Author

IMO not only Go. I think that the default value is wrongly defined in other languages. And also I think the clarification is needed for all languages.

@svrnm svrnm changed the title Document environment variables in Go Sampling Document environment variables in Sampling Oct 2, 2023
@svrnm
Copy link
Member

svrnm commented Oct 2, 2023

Ok. I removed the "Go" from the title :)

@pellared pellared removed the sig:go label Oct 9, 2023
@svrnm svrnm added help wanted Extra attention is needed docs 0-meta and removed good first issue Good for newcomers labels Oct 18, 2023
@svrnm svrnm changed the title Document environment variables in Sampling [meta] Document environment variables in Sampling Oct 18, 2023
@svrnm
Copy link
Member

svrnm commented Oct 18, 2023

@pellared turning this into a meta issue since it is relevant for all languages

@nerudadhich
Copy link
Contributor

Hi @svrnm, I would like to start working on this. Will start from Java first.
Do we have any ideal format that we need to follow for this ? Any example from existing one's ?

@svrnm
Copy link
Member

svrnm commented Apr 8, 2024

Hi @svrnm, I would like to start working on this. Will start from Java first. Do we have any ideal format that we need to follow for this ? Any example from existing one's ?

Apologies for the late reply, I was out of office. We currently have #4199 open, so it might need that to be closed before we can add some words about variables. You can review that PR if you like and create a follow up when merged.

@svrnm svrnm closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-meta docs help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants