-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[meta] Document environment variables in Sampling #3325
Comments
We should also probably call out that using |
is this only a go thing? |
IMO not only Go. I think that the default value is wrongly defined in other languages. And also I think the clarification is needed for all languages. |
Ok. I removed the "Go" from the title :) |
@pellared turning this into a meta issue since it is relevant for all languages |
Hi @svrnm, I would like to start working on this. Will start from Java first. |
Apologies for the late reply, I was out of office. We currently have #4199 open, so it might need that to be closed before we can add some words about variables. You can review that PR if you like and create a follow up when merged. |
I think we should also document setting the environment variable in a top-level section in this guide. That can be especially helpful for development since you can just use the default, but then have production do something different.
Originally posted by @cartermp in #3318 (review)
Also #3318 (comment)
(edit by @svrnm)
Tracking:
The text was updated successfully, but these errors were encountered: