Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Textlint fails locally but not in GH action #3119

Closed
chalin opened this issue Jul 31, 2023 · 3 comments · Fixed by #3120
Closed

[CI] Textlint fails locally but not in GH action #3119

chalin opened this issue Jul 31, 2023 · 3 comments · Fixed by #3120
Labels
CI/infra CI & infrastructure

Comments

@chalin
Copy link
Contributor

chalin commented Jul 31, 2023

Here's the output of when I run the linter locally:

> check:text
> npm run _check:text


> _check:text
> npx textlint content data


/Users/chalin/git/lf/open-telemetry/opentelemetry.io/content/en/docs/instrumentation/php/automatic.md
  102:22  ✓ error  Incorrect usage of the term: “php”, use “PHP” instead  terminology

✖ 1 problem (1 error, 0 warnings)
✓ 1 fixable problem.
Try to run: $ textlint --fix [file]

ERROR: "check:text" exited with 1.
ERROR: "check" exited with 1.

Maybe the script that generates errors for GH gobbles up the failure sometimes? /cc @svrnm

@svrnm
Copy link
Member

svrnm commented Aug 1, 2023

@chalin I can not reproduce that error

@chalin chalin mentioned this issue Aug 1, 2023
12 tasks
@chalin
Copy link
Contributor Author

chalin commented Aug 1, 2023

@svrnm - we can see the problem in GH too. For that and a fix, see #3120.

@svrnm
Copy link
Member

svrnm commented Aug 1, 2023

@chalin then my local repo might be off 🤷 I approved the PR looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants