Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on collector deployment #2692

Open
mhausenblas opened this issue May 10, 2023 · 7 comments
Open

Follow up on collector deployment #2692

mhausenblas opened this issue May 10, 2023 · 7 comments
Labels
enhancement New feature or request help wanted Extra attention is needed sig:collector

Comments

@mhausenblas
Copy link
Member

In #2498 we parked a few things that should be addressed ASAP in a follow-up PR. They are:

Changes for follow up PR for #2498

In agent.md

Expand on the cons for the agent pattern, that is, flesh out the following:

  • Scalability (human and load-wise)
  • Inflexible

In best-practices.md

  • replace Jaeger exporter with OTLP exporter
  • simplify by configuring both exporters for the same pipeline in metrics/prod
  • make sure we use attributes covered by the semantic conventions across the doc

Replace:

processors:
  attributes:
    actions:
      - key: cluster
        value: eu-west-1
        action: upsert
  metricstransform:
    transforms:
      - include: otelcol_process_uptime
        action: update
        operations:
          - action: add_label
            new_label: cluster
            new_value: eu-west-1

With:

transform:
  error_mode: ignore
  trace_statements:
    - context: span
      statements:
        - set(attributes["cluster"], "eu-west-1") 
  metric_statements:
    - context: datapoint
      statements:
        - set(attributes["cluster"], "eu-west-1") where metric.name == "otelcol_process_uptime

In collector/_index.md

Replace #when-to-use-a-collector with one that calls out all the deployment patterns and mentions that there is one for no collector and what the advantages/disadvantages are.

@mhausenblas mhausenblas added the bug Something isn't working label May 10, 2023
@mhausenblas mhausenblas self-assigned this May 10, 2023
@mhausenblas
Copy link
Member Author

In gateway.md update the note that says LB exporter only supports traces (it also supports logs).

@svrnm svrnm added enhancement New feature or request sig:collector and removed bug Something isn't working labels May 11, 2023
@theletterf
Copy link
Member

@mhausenblas What's missing to close the issue?

@mhausenblas
Copy link
Member Author

@theletterf as per above. We might need to pause/archive/attic it for now, I won't have cycles for it in the near future

@svrnm svrnm added the help wanted Extra attention is needed label Apr 15, 2024
@svrnm
Copy link
Member

svrnm commented Apr 15, 2024

Thanks for clarification, I removed the assignment and added a help wanted label such that people can pick it up

@Ananyasinha13
Copy link

Can you assign this issue to me.

@Ananyasinha13
Copy link

Can you share me the repo link

@svrnm
Copy link
Member

svrnm commented Sep 11, 2024

Can you assign this issue to me.

We do not assign issues, please go ahead and provide a PR for this issue if you want to work on it, it can be an early draft or an incremental change, depending on the complexity. Repo URL is https://github.com/open-telemetry/opentelemetry.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed sig:collector
Projects
None yet
Development

No branches or pull requests

4 participants