Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -f--proto '=https --tlsv1.2' for curl commands #2633

Closed
svrnm opened this issue Apr 25, 2023 · 0 comments · Fixed by #2634
Closed

Use -f--proto '=https --tlsv1.2' for curl commands #2633

svrnm opened this issue Apr 25, 2023 · 0 comments · Fixed by #2634

Comments

@svrnm
Copy link
Member

svrnm commented Apr 25, 2023

I think we should use -f to fail clearly on 404s. It also seems like a good idea to add --proto '=https --tlsv1.2 to force curl to use HTTPS with TLS v1.2 for increased security (these options are used by e.g. the Rust official install instructions so I assume they are widely supported).

So on this particular line the curl invocation could be rewritten as:

curl --proto '=https' --tlsv1.2 -fOL https://github.com/open-telemetry/opentelemetry-collector-releases/releases/download/v{{% param collectorVersion %}}/otelcol_{{% param collectorVersion %}}_linux_386.tar.gz

Originally posted by @mx-psi in #2626 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant