Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming? #1777

Closed
reyang opened this issue Sep 23, 2022 · 18 comments
Closed

Consistent naming? #1777

reyang opened this issue Sep 23, 2022 · 18 comments
Labels
bug Something isn't working docs

Comments

@reyang
Copy link
Member

reyang commented Sep 23, 2022

What needs to be changed?

The current docs seem to use inconsistent names for different language clients.

For example:

image

image

image

image

Making it worse, the website is also different from the official project:

image

image

What is the name + path of the page that needs changed?

Almost all the docs under https://github.com/open-telemetry/opentelemetry.io/tree/main/content/en/docs/instrumentation

@reyang reyang added the bug Something isn't working label Sep 23, 2022
@alolita
Copy link
Member

alolita commented Sep 23, 2022

Good callout @reyang +1 on maintaining consistent naming.

@svrnm
Copy link
Member

svrnm commented Sep 23, 2022

Thanks for bringing this up, @reyang! I am not sure if this is a sole issue for the website or for all the SIGs as well (as you called out there are differences in the repo names as well). I raised a similar topic a while back rg. the auto instrumentation where we have a similar situation: #1689

We fixed that for a few of the language index pages via this PR: #1732

Not sure if this is a decision we can solely make from the website?

@reyang
Copy link
Member Author

reyang commented Sep 23, 2022

Not sure if this is a decision we can solely make from the website?

Aha, I don't know! That's why I raised this issue to test the water 🤣🤣🤣

@cartermp
Copy link
Contributor

We can certainly standardize on naming on the website, but yeah, this might be a "each SIG decides what the name is" sorta deal. Which would then lead to inconsistent naming for sure. Ah, bikesheds.

@svrnm
Copy link
Member

svrnm commented Sep 26, 2022

Please see my lengthy comment here: #1689 (comment)

@svrnm
Copy link
Member

svrnm commented Sep 27, 2022

For the initial question, I think it should be "OpenTelemetry for <Language>"? That's at least what most language pages have (especially due to #1732, where we started to use the same text for most language pages).

@cartermp
Copy link
Contributor

Agreed.

@reyang
Copy link
Member Author

reyang commented Sep 27, 2022

For the initial question, I think it should be "OpenTelemetry for <Language>"? That's at least what most language pages have (especially due to #1732, where we started to use the same text for most language pages).

"For" could be confusing for clients that are targeting more than the programming language. For example:

  • "OpenTelemetry for Java" sounds like it is for Java, although it can be used by Scala or any other languages targeting JVM.
  • "OpenTelemetry for JavaScript" sounds like it is for JavaScript, however it can be used by TypeScript/CoffeeScript/etc.

@svrnm
Copy link
Member

svrnm commented Sep 28, 2022

That's a point against "for" indeed. Not that I would rule it out because of that but maybe we can do better, so what are the alternatives we have?

  1. OpenTelemetry for C++, OpenTelemetry for Rust
  2. OpenTelemetry Java, OpenTelemetry JavaScript
  3. OpenTelemetry in .NET, OpenTelemetry in Python
  4. OpenTelemetry Go SDK, OpenTelemetry Ruby SDK (and ... API, etc.)

@reyang
Copy link
Member Author

reyang commented Sep 28, 2022

Maybe we can collect feedback here - vote with emoji:

  1. ❤️ OpenTelemetry C++, OpenTelemetry Rust, OpenTelemetry Java, OpenTelemetry JavaScript, OpenTelemetry .NET, OpenTelemetry Python, OpenTelemetry Go, OpenTelemetry Ruby
  2. 🎉 OpenTelemetry in C++, OpenTelemetry in Rust, OpenTelemetry in Java, OpenTelemetry in JavaScript, OpenTelemetry in .NET, OpenTelemetry in Python, OpenTelemetry in Go, OpenTelemetry in Ruby
  3. 🚀 OpenTelemetry for C++, OpenTelemetry for Rust, OpenTelemetry for Java, OpenTelemetry for JavaScript, OpenTelemetry for .NET, OpenTelemetry for Python, OpenTelemetry for Go, OpenTelemetry for Ruby

@cartermp cartermp added the docs label Sep 29, 2022
@svrnm
Copy link
Member

svrnm commented Oct 4, 2022

So, we have a strong preference for "OpenTelemetry "?

We can change that throughout the docs, but for consistency we should also have the same for the individual repos, and I think that's something that needs to be discussed via open-telemetry/community?

@reyang
Copy link
Member Author

reyang commented Oct 4, 2022

We can change that throughout the docs, but for consistency we should also have the same for the individual repos, and I think that's something that needs to be discussed via open-telemetry/community?

I've reached out to several groups on Slack gathering feedback:

  1. OpenTelemetry Maintainers https://cloud-native.slack.com/archives/C01NJ7V1KRC/p1664914229223519
  2. OpenTelemetry Community https://cloud-native.slack.com/archives/CJFCJHG4Q/p1664914268959639
  3. OpenTelemetry Demo https://cloud-native.slack.com/archives/C03B4CWV4DA/p1664914257596769

@pellared
Copy link
Member

pellared commented Oct 5, 2022

@reyang Could we also try consistently naming the "auto-instrumentation" repositories or is it too much for this issue?

Current state:

  1. OpenTelemetry Instrumentation for Java
  2. OpenTelemetry .NET Automatic Instrumentation
  3. OpenTelemetry auto-instrumentation extension

Proposals:

  1. ❤️ OpenTelemetry ABC Auto-Instrumentation OR OpenTelemetry Auto-Instrumentation for ABC
  2. 🎉 OpenTelemetry ABC Automatic Instrumentation OR OpenTelemetry Automatic Instrumentation for ABC
  3. 🚀 OpenTelemetry ABC Instrumentation OR OpenTelemetry Instrumentation for ABC

@mateuszrzeszutek
Copy link
Member

Some of the modules released as part of https://github.com/open-telemetry/opentelemetry-java-instrumentation are not really automatic instrumentation: these library instrumentations have to be added as a dependency, and then configured and installed into the instrumented framework by the user. If possible, I'd refrain from renaming the repo to "auto-instrumentation"

@svrnm
Copy link
Member

svrnm commented Oct 6, 2022

@pellared , @mateuszrzeszutek I would prefer to have this in a separate issue, because this is a much more complicated case (see also the discussion at #1689). A layer of complexity that you called out, @mateuszrzeszutek, is that the content of the opentelemetry--(instrumentation|contrib) repositories is not consistent, so this is not a discussion that we should have here at the opentelemetry.io repo.

@reyang
Copy link
Member Author

reyang commented Oct 20, 2022

Getting back here, open-telemetry/opentelemetry-specification#2867 is merged. Thanks everyone who contributed to the discussion and shared your opinions/votes.

@reyang
Copy link
Member Author

reyang commented Oct 20, 2022

@svrnm FYI I've done some grunt work to align the existing projects:

I'll keep this issue open since there are still several places in the docs where we need to address.

@cartermp
Copy link
Contributor

@reyang thanks for filing. I believe this can now be closed since all language index pages use the same pattern for the name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs
Projects
None yet
Development

No branches or pull requests

6 participants