-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent naming? #1777
Comments
Good callout @reyang +1 on maintaining consistent naming. |
Thanks for bringing this up, @reyang! I am not sure if this is a sole issue for the website or for all the SIGs as well (as you called out there are differences in the repo names as well). I raised a similar topic a while back rg. the auto instrumentation where we have a similar situation: #1689 We fixed that for a few of the language index pages via this PR: #1732 Not sure if this is a decision we can solely make from the website? |
Aha, I don't know! That's why I raised this issue to test the water 🤣🤣🤣 |
We can certainly standardize on naming on the website, but yeah, this might be a "each SIG decides what the name is" sorta deal. Which would then lead to inconsistent naming for sure. Ah, bikesheds. |
Please see my lengthy comment here: #1689 (comment) |
For the initial question, I think it should be "OpenTelemetry for |
Agreed. |
"For" could be confusing for clients that are targeting more than the programming language. For example:
|
That's a point against "for" indeed. Not that I would rule it out because of that but maybe we can do better, so what are the alternatives we have?
|
Maybe we can collect feedback here - vote with emoji:
|
So, we have a strong preference for "OpenTelemetry "? We can change that throughout the docs, but for consistency we should also have the same for the individual repos, and I think that's something that needs to be discussed via open-telemetry/community? |
I've reached out to several groups on Slack gathering feedback:
|
@reyang Could we also try consistently naming the "auto-instrumentation" repositories or is it too much for this issue? Current state:
Proposals:
|
Some of the modules released as part of https://github.com/open-telemetry/opentelemetry-java-instrumentation are not really automatic instrumentation: these library instrumentations have to be added as a dependency, and then configured and installed into the instrumented framework by the user. If possible, I'd refrain from renaming the repo to "auto-instrumentation" |
@pellared , @mateuszrzeszutek I would prefer to have this in a separate issue, because this is a much more complicated case (see also the discussion at #1689). A layer of complexity that you called out, @mateuszrzeszutek, is that the content of the opentelemetry--(instrumentation|contrib) repositories is not consistent, so this is not a discussion that we should have here at the opentelemetry.io repo. |
Getting back here, open-telemetry/opentelemetry-specification#2867 is merged. Thanks everyone who contributed to the discussion and shared your opinions/votes. |
@svrnm FYI I've done some grunt work to align the existing projects: I'll keep this issue open since there are still several places in the docs where we need to address. |
@reyang thanks for filing. I believe this can now be closed since all language index pages use the same pattern for the name. |
What needs to be changed?
The current docs seem to use inconsistent names for different language clients.
For example:
Making it worse, the website is also different from the official project:
What is the name + path of the page that needs changed?
Almost all the docs under https://github.com/open-telemetry/opentelemetry.io/tree/main/content/en/docs/instrumentation
The text was updated successfully, but these errors were encountered: