Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider having the k8sattributesprocessor in the default configuration for Collector Getting Started with K8s #1538

Open
cartermp opened this issue Jul 8, 2022 · 4 comments
Labels
discussion Input from everyone is helpful to drive this forward docs e2-days Effort: < 5 days sig:collector upstream

Comments

@cartermp
Copy link
Contributor

cartermp commented Jul 8, 2022

This was discussed in #370

Today, we point at a manifest that doesn't have the k8sattributesprocessor. It's a very valuable processor that people are likely to use when in the context of k8s.

Currently, the file we recommend pulling in lives in the upstream collector repo. So if that file were to change, it'd have to include the processor. Otherwise, we'd have to consider a different command to get started with.

@svrnm
Copy link
Member

svrnm commented Jul 17, 2022

You mean https://raw.githubusercontent.com/open-telemetry/opentelemetry-collector/main/examples/k8s/otel-config.yaml ?

That issue should then be raised with the collector repo?

@TylerHelmuth
Copy link
Member

The reason it isn't included by default in that example, and why it isn't included by default in the collector helm chart, is that it requires extra permissions. Requiring elevated permissions in a default scenario gets kinda tricky.

@cartermp
Copy link
Contributor Author

Hmm, in that case, would it be helpful to have a subsection in there that tells you how to use the processor and then specify which permissions you need to do so?

@TylerHelmuth
Copy link
Member

Sure, the processor's documentation has a good RBAC section to help users. Should be able to link to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Input from everyone is helpful to drive this forward docs e2-days Effort: < 5 days sig:collector upstream
Projects
None yet
Development

No branches or pull requests

4 participants