From 97521b966d9133aa09178140a26d0234755e6922 Mon Sep 17 00:00:00 2001 From: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com> Date: Fri, 14 Jun 2024 09:36:49 +0000 Subject: [PATCH] Results from /fix:all --- content/en/docs/contributing/development.md | 35 ++++++++++++--------- static/refcache.json | 8 +++++ 2 files changed, 28 insertions(+), 15 deletions(-) diff --git a/content/en/docs/contributing/development.md b/content/en/docs/contributing/development.md index f469e907e06d..39d8cc5a6a2a 100644 --- a/content/en/docs/contributing/development.md +++ b/content/en/docs/contributing/development.md @@ -131,22 +131,27 @@ approvers and maintainers while doing code reviews: one by a SIG approver: - Doc approver label such PRs with `sig:` and tag the SIG `-approvers` group on that PR - - After a doc approver has reviewed and approved the PR, they can add the label + - After a doc approver has reviewed and approved the PR, they can add the + label [`sig-approval-missing`](https://github.com/open-telemetry/opentelemetry.io/labels/sig-approval-missing). This signals to the SIG that they need to handle the PR - If no SIG approval is given within a certain grace period (two weeks in general, but may be less in urgent cases), docs maintainer may use their own judgement to merge that PR - PRs created by bots can be merged by the following practice: - - PRs that auto-update versions in the registry can be fixed, approved and merged immediately - - PRs that auto-update the versions of SDKs, zero-code instrumentations or the collector - can be approved and merged except the corresponding SIG signals that merging should be postponed - - PRs that auto-update the version of any specification often require updates to scripts for the CI - checks to pass. In that case often [@chalin](https://github.com/chalin/) will handle that PR. - Otherwise those PRs can as well be approved and merged except the corresponding SIG signals that - merging should be postponed -- PRs with changes to translations should aim for two approvals: one by a docs approver - and one by a translation approver. Similar practices apply as suggested for the co-owned PRs. + - PRs that auto-update versions in the registry can be fixed, approved and + merged immediately + - PRs that auto-update the versions of SDKs, zero-code instrumentations or the + collector can be approved and merged except the corresponding SIG signals + that merging should be postponed + - PRs that auto-update the version of any specification often require updates + to scripts for the CI checks to pass. In that case often + [@chalin](https://github.com/chalin/) will handle that PR. Otherwise those + PRs can as well be approved and merged except the corresponding SIG signals + that merging should be postponed +- PRs with changes to translations should aim for two approvals: one by a docs + approver and one by a translation approver. Similar practices apply as + suggested for the co-owned PRs. - If the PR branch is `out-of-date with the base branch`, they do not need to be updated continuously: every update triggers all the PR CI checks to be run! It's often enough to update them before merging. @@ -161,9 +166,9 @@ approvers and maintainers while doing code reviews: - Words unknown to cspell should be added to the cspell ignore list per page by PR authors. Only approvers and maintainers will add commonly used terms to the global list. -- Approvers and maintainers have different work schedules and circumstances. That's why all - communication is assumed to be asynchronously and they should not feel obligated to reply - outside of their normal schedule. +- Approvers and maintainers have different work schedules and circumstances. + That's why all communication is assumed to be asynchronously and they should + not feel obligated to reply outside of their normal schedule. - When an approver or maintainer won't be available to contribute for an extended period of time (more than a few days or a week) or won't be available in that period of time, they should communicate this using the @@ -174,8 +179,8 @@ The following workflow can be applied by maintainers to merge PRs: - Make sure that a PR has all approvals and all CI checks pass - If the branch is out-of-date, update it via the GitHub UI. -- The update will trigger all CI checks to run again, wait for them to pass - or execute a script like the following to make it happen in the background: +- The update will trigger all CI checks to run again, wait for them to pass or + execute a script like the following to make it happen in the background: ```shell export PR=; gh pr checks ${PR} --watch && gh pr merge ${PR} --squash diff --git a/static/refcache.json b/static/refcache.json index d29d9abe4deb..fcfc3e993607 100644 --- a/static/refcache.json +++ b/static/refcache.json @@ -2503,6 +2503,10 @@ "StatusCode": 200, "LastSeen": "2024-01-30T15:25:16.58574-05:00" }, + "https://github.com/chalin/": { + "StatusCode": 200, + "LastSeen": "2024-06-14T09:35:29.965101669Z" + }, "https://github.com/cloudflare/cfssl": { "StatusCode": 200, "LastSeen": "2024-01-18T19:36:55.954418-05:00" @@ -4311,6 +4315,10 @@ "StatusCode": 200, "LastSeen": "2024-01-18T19:09:43.270324-05:00" }, + "https://github.com/open-telemetry/opentelemetry.io/labels/sig-approval-missing": { + "StatusCode": 200, + "LastSeen": "2024-06-14T09:35:27.61260596Z" + }, "https://github.com/open-telemetry/opentelemetry.io/pull/2130": { "StatusCode": 200, "LastSeen": "2024-01-30T15:26:13.725828-05:00"